public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v4 1/2] fix #5267: storage: add bzip2 support
Date: Thu, 7 Nov 2024 11:35:52 +0100	[thread overview]
Message-ID: <d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com> (raw)
In-Reply-To: <20240913081352.76932-1-m.sandoval@proxmox.com>

Does what it says. Tested in combination with the adjacent UI patch [0].


[0] 
https://lore.proxmox.com/pve-devel/20240802143736.172810-1-m.sandoval@proxmox.com/

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2024-09-13  10:13, Maximiliano Sandoval wrote:
> A popular ISO compressed exclusively with bz2 is OPNsense [2].
> 
> Since this requires adding `bz2` to the list of known compression
> formats we add decompression methods for vmz and tar.
> 
> [2] https://opnsense.org/download/
> 
> Suggested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Differences from v3:
>   - Remove gzip dependency from d/control
>   - Fix typo in commit message
>   - Add bz2 to VZTMPL_EXT_RE_1 regex which allow us to:
>   - Fix tests
> 
> Differences from v2:
>   - Fix typo s/lzpo/lzop
>   - Add fix to commit message
> 
> Differences from v1:
>   - Add more context to commit message
>   - Add decompression utilities as explicit dependencies
> 
>   src/PVE/Storage.pm                 |  5 ++++-
>   src/PVE/Storage/Plugin.pm          |  2 +-
>   src/test/archive_info_test.pm      |  6 ++++--
>   src/test/list_volumes_test.pm      | 20 ++++++++++++++++++--
>   src/test/parse_volname_test.pm     | 14 +++++++-------
>   src/test/path_to_volume_id_test.pm | 26 ++++++++++++++++----------
>   6 files changed, 50 insertions(+), 23 deletions(-)
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-11-07 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  8:13 Maximiliano Sandoval
2024-09-13  8:13 ` [pve-devel] [PATCH storage v4 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd Maximiliano Sandoval
2024-09-13  8:23   ` Fabian Grünbichler
2024-09-13  8:25     ` Maximiliano Sandoval
2024-10-01 11:03       ` Maximiliano Sandoval
2024-10-07 11:57         ` Maximiliano Sandoval
2024-10-14 12:19           ` Maximiliano Sandoval
2024-11-05 10:31             ` Maximiliano Sandoval
2024-11-07 10:35 ` Aaron Lauterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal