From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-partially: [PATCH-SERIES v2 manager] Make backup with IDs for non-existent guests visibly fail
Date: Thu, 22 Oct 2020 18:52:04 +0200 [thread overview]
Message-ID: <d793c85f-f392-bcc2-a7cc-a7a185887cb5@proxmox.com> (raw)
In-Reply-To: <20201022103017.19715-1-f.ebner@proxmox.com>
On 22.10.20 12:30, Fabian Ebner wrote:
> #1 and #2 are just cleanups
>
> #3 and #4 make the necessary changes for the improved behavior
> by ensuring that exec_backup_task will cleanly fail when there
> is no plugin specified, and then including the orphaned IDs
> without assigning them a plugin. This is closer to the behavior
> of PVE 6.0 and ensures that the backup task is marked as failed,
> and the mail notification includes an error for the orphaned IDs.
>
> #5 ensures that the IDs are still numerically ordered when there
> are non-existing guests
>
> #6 and #7 are minor improvements and can be applied independently
>
> #8 is an RFC and changes the data structure returned by get_included_guests
>
>
> Changes from v1:
> * everything, as the approach is different
>
>
> Fabian Ebner (8):
> remove unused variable
> remove out-of-date comment
> only use plugin after truthiness check
> backup: include IDs for non-existent guests
> order guest IDs numerically in exec_backup
> sort the skip list numerically
> simplify get_included_vmids function
> don't group by node in get_included_guests
>
> PVE/API2/Backup.pm | 23 ++--
> PVE/API2/BackupInfo.pm | 18 +---
> PVE/API2/VZDump.pm | 19 +++-
> PVE/VZDump.pm | 68 +++++++-----
> test/vzdump_guest_included_test.pl | 163 ++++++++++++++++++++++++++---
> 5 files changed, 212 insertions(+), 79 deletions(-)
>
applied all but the RFC, not for any specific reason but I had to cut an release,
thanks!
prev parent reply other threads:[~2020-10-22 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 10:30 [pve-devel] " Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 1/8] remove unused variable Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 2/8] remove outdated comment Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 3/8] only use plugin after truthiness check Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 4/8] backup: include IDs for non-existent guests Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 5/8] order guest IDs numerically in exec_backup Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 6/8] sort the skip list numerically Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [PATCH v2 manager 7/8] simplify get_included_vmids function Fabian Ebner
2020-10-22 10:30 ` [pve-devel] [RFC/PATCH v2 manager 8/8] don't group by node in get_included_guests Fabian Ebner
2020-10-22 16:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d793c85f-f392-bcc2-a7cc-a7a185887cb5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox