From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dylan Whyte <d.whyte@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-manager] vzdump: add error if passed in hook script doesn't exist
Date: Thu, 28 Apr 2022 18:44:41 +0200 [thread overview]
Message-ID: <d764e094-a62d-20d3-d66b-0bd1fc522f3f@proxmox.com> (raw)
In-Reply-To: <20220428145706.274322-1-d.whyte@proxmox.com>
On 28.04.22 16:57, Dylan Whyte wrote:
> Previously, if the '--script' argument was passed with a non-existent
> file, it would state that a non-executable script was the reason for
> failure. This adds a check to see if the hook script exists, in order
> to provide a more accurate error message.
>
> Also adds an 'Error:' prefix the 'script not executable' error.
>
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
> PVE/VZDump.pm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-04-28 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 14:57 [pve-devel] " Dylan Whyte
2022-04-28 16:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d764e094-a62d-20d3-d66b-0bd1fc522f3f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.whyte@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox