From: Folke Gleumes <f.gleumes@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
Subject: Re: [pve-devel] [PATCH v2 access-control] fix #5335: stable sorting in user.cfg
Date: Tue, 16 Apr 2024 12:53:36 +0200 [thread overview]
Message-ID: <d6da05811de7ab44350441559e386894de5f62dc.camel@proxmox.com> (raw)
In-Reply-To: <mailman.427.1713254851.450.pve-devel@lists.proxmox.com>
Hi,
thanks for your contribution!
Looks fine to me. The saving function itself already sorts everything
else, so this should be the last point where it can be indeterministic.
While at it, could you update the foreach to a for? Not all code
already agrees with our style guide, but we try to update it whenever
we are touching it [0].
If you haven't done so already, you need to agree to the Harmony CLI
before we can accept your contribution [1].
Gave it a spin and ran some configurations, so you can consider this:
Tested-by: Folke Gleumes <f.gleumes@proxmox.com>
[0] https://pve.proxmox.com/wiki/Perl_Style_Guide
[1]
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
On Tue, 2024-04-16 at 09:27 +0200, Daniel Krambrock via pve-devel
wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next parent reply other threads:[~2024-04-16 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.427.1713254851.450.pve-devel@lists.proxmox.com>
2024-04-16 10:53 ` Folke Gleumes [this message]
2024-04-16 12:25 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6da05811de7ab44350441559e386894de5f62dc.camel@proxmox.com \
--to=f.gleumes@proxmox.com \
--cc=krambrock@hrz.uni-marburg.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox