Re: [pve-devel] [PATCH ha-manager 9/9] handle node affinity rules with failback in manual migrations

[Fiona Ebner <f.ebner@proxmox.com>]

Am 19.01.26 um 4:41 PM schrieb Daniel Kral:
> On Mon Jan 19, 2026 at 4:00 PM CET, Fiona Ebner wrote:
>> Am 15.12.25 um 4:55 PM schrieb Daniel Kral:
>>> diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
>>> index f8c5965e..fa14816c 100644
>>> --- a/src/PVE/HA/Config.pm
>>> +++ b/src/PVE/HA/Config.pm
>>> @@ -382,22 +382,27 @@ sub service_is_configured {
>>>  sub get_resource_motion_info {
>>>      my ($sid) = @_;
>>>  
>>> -    my $resources = read_resources_config();
>>> +    my $conf = read_resources_config();
>>
>> Nit: maybe it's slightly nicer to use read_and_compile_rules_config()
>> already here and avoid a second read call below?
> 
> I guess you meant read_and_check_resources_config() here ;)

Yes, sorry, copy-pasted the wrong one :)

> 
> The service_check_ha_state(...) helper below assumes a parsed section
> config (and is used in a bunch of places), while
> read_and_check_resources_config() will return a modified version of the
> resource config (defaults set, etc.).

Oh, right. I thought the structure of the results is the same, but the
first one has the data below the 'ids' key.

> What isn't nice at all here is that read_and_compile_rules_config()
> reads the manager status and resource config a second and third time and
> since it's only used here at the moment I'll make it a private helper
> instead of reading on its own.

Ack.

> 
> For read_and_check_resources_config() I'd move out the inner logic into
> a separate private helper, so that all of get_resource_motion_info(...)
> does work with the same single read from the resource config.

Ack.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel