public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-network] fix #5275: remove priority field from powerdns
@ 2024-03-04 14:11 Stefan Hanreich
  2024-03-04 16:09 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2024-03-04 14:11 UTC (permalink / raw)
  To: pve-devel

Since v3.4.2 the priority field has been removed and since v4.9 they
are actively rejected by PowerDNS. Stop sending this field in order to
make the PowerDNS plugin work with versions >= 4.9 again. [1]

[1] https://doc.powerdns.com/authoritative/upgrading.html#api-changes

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm b/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm
index 096d131..5564120 100644
--- a/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm
+++ b/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm
@@ -69,8 +69,7 @@ sub add_a_record {
     my $record = { content => $ip, 
                    disabled => JSON::false, 
 		   name => $fqdn, 
-                   type => $type, 
-                   priority => 0 };
+                   type => $type };
 
     push @$final_records, $record;
 
@@ -108,8 +107,7 @@ sub add_ptr_record {
     my $record = { content => $hostname, 
                    disabled => JSON::false, 
 		   name => $reverseip, 
-                   type => $type, 
-                   priority => 0 };
+                   type => $type };
 
     my $rrset = { name => $reverseip, 
 		  type => $type, 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH pve-network] fix #5275: remove priority field from powerdns
  2024-03-04 14:11 [pve-devel] [PATCH pve-network] fix #5275: remove priority field from powerdns Stefan Hanreich
@ 2024-03-04 16:09 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-03-04 16:09 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stefan Hanreich

Am 04/03/2024 um 15:11 schrieb Stefan Hanreich:
> Since v3.4.2 the priority field has been removed and since v4.9 they
> are actively rejected by PowerDNS. Stop sending this field in order to
> make the PowerDNS plugin work with versions >= 4.9 again. [1]
> 
> [1] https://doc.powerdns.com/authoritative/upgrading.html#api-changes
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-04 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-04 14:11 [pve-devel] [PATCH pve-network] fix #5275: remove priority field from powerdns Stefan Hanreich
2024-03-04 16:09 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal