From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: resource tree: add collapse/expand all button
Date: Tue, 19 Nov 2024 10:46:04 +0100 [thread overview]
Message-ID: <d639248e-97f8-49c0-8841-0ab7e44ed5bc@proxmox.com> (raw)
In-Reply-To: <760bb5c6-459c-425d-829a-0c63afe6896f@proxmox.com>
Am 19.11.24 um 10:41 schrieb Dominik Csapak:
> true, i'll send a v2 with two buttons, icons are ok for you or do you have a different
> sugggestion?
>
And don't get me wrong, that's certainly minor, but if the single button
is already not ideal implementation wise it might be worth to try.
Another option might be to have those stacked, I agree that it is slightly
niche, and thus having this a bit tinier can be still enough I think.
W.r.t. icons, as they're wrapped in a x-btn-icon-el-default-toolbar-small they
should look like the setting gear beside it, or? In that case it might be fine
to use the plus/minus without any square, but no hard feelings.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-19 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:22 Dominik Csapak
2024-11-19 9:30 ` Thomas Lamprecht
2024-11-19 9:36 ` Dominik Csapak
2024-11-19 9:39 ` Thomas Lamprecht
2024-11-19 9:41 ` Dominik Csapak
2024-11-19 9:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d639248e-97f8-49c0-8841-0ab7e44ed5bc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox