From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths
Date: Wed, 23 Jul 2025 15:33:32 +0200 [thread overview]
Message-ID: <d5e82ad6-89be-4cc4-a62f-932572c7e452@proxmox.com> (raw)
In-Reply-To: <20250723132116.117742-1-f.ebner@proxmox.com>
Am 23.07.25 um 3:21 PM schrieb Fiona Ebner:
> With the switch to '-blockdev', it is necessary to explicitly specify
> the device ID for SCSI drives, see also [0]. Otherwise, the device
> paths in '/dev/disk/by-id' would be missing. For IDE/SATA, the paths
> are still present with '-blockdev' without additional changes and
> VirtIO block did not have such paths even before. The relevant
> 'ide-{cd,hd}' and 'virtio-blk-pci' devices do not seem to have an
> option that would be equivalent to the 'scsi-{cd,hd}' 'device_id'
> option.
>
> While the change should be backwards-compatible even with '-drive',
> guard it with machine version 10.0 just to be sure.
>
> [0]: https://gitlab.com/libvirt/libvirt/-/commit/a1dce96236f6d35167924fa7e6a70f58f394b23c
>
> Fixes: aaf48d8e ("command line: switch to blockdev starting with machine version 10.0")
> Co-developed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> v2: resend with --transfer-encoding=base64
Seems like the list auto-converts to
Content-Transfer-Encoding: 7bit
and breaks it again...
I created a blockdev-fixups branch in my qemu-server staff repo for this.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 13:20 Fiona Ebner
2025-07-23 13:20 ` [pve-devel] [PATCH v2 qemu-server 2/2] fix #6556: vm status: fix querying block stats Fiona Ebner
2025-07-23 13:33 ` Fiona Ebner [this message]
2025-07-23 13:38 ` [pve-devel] [PATCH v2 qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths Fiona Ebner
2025-07-23 13:40 ` Hannes Duerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e82ad6-89be-4cc4-a62f-932572c7e452@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox