From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field
Date: Thu, 22 Sep 2022 12:35:30 +0200 [thread overview]
Message-ID: <d583f220-e669-cd32-bb53-ba5663686fe4@proxmox.com> (raw)
In-Reply-To: <20220721104559.302270-1-m.heiserer@proxmox.com>
all 3 patches LGTM
the only (minor) thing is that the wt patch could have handled the current situation
(pve raw+value, pbs normalized+value), e.g by using the field 'convert' or 'calculate'
methods of extjs (we could have had a 'real_raw' and 'real_normalized' that uses
the values depending on which exist) then we would not need a depends/breaks on the
versions (not sure which direction here)
if everybody else is ok with these dependencies, consider these patches:
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.cspak@proxmox.com>
next prev parent reply other threads:[~2022-09-22 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:45 Matthias Heiserer
2022-07-21 10:45 ` [pve-devel] [PATCH pve-storage] fix #4165: disk: SMART: add normalized field Matthias Heiserer
2022-09-23 10:29 ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2022-07-21 10:45 ` [pve-devel] [PATCH widget-toolkit] fix #4165: SMART: use changed columns from the API Matthias Heiserer
2022-09-22 10:35 ` Dominik Csapak [this message]
2022-09-23 10:31 ` [pve-devel] [pbs-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field Thomas Lamprecht
2022-09-23 10:28 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d583f220-e669-cd32-bb53-ba5663686fe4@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox