public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stephan Leemburg <sleemburg@it-functions.nl>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] More than 10 interfaces in lxc containers
Date: Sat, 22 Aug 2020 23:41:44 +0200	[thread overview]
Message-ID: <d4c75d3b-88e6-36db-9c05-88254a305d4a@it-functions.nl> (raw)

Hi @dev,

I have read about other people who need more than 10 network interfaces 
in their lxc containers.

For me, I have that need too for a firewall container.

I think it is not so difficult to raise the 10 upto 32.

Just change

/usr/share/pve-manager/js/pvemanagerlib.js

in Ext.define('PVE.lxc.NetworkView', {

the line

me.down('button[name=addButton]').setDisabled((records.length >= 10));

to

me.down('button[name=addButton]').setDisabled((records.length >= 32));

And in

/usr/share/perl5/PVE/LXC/Config.pm change

my $MAX_LXC_NETWORKS = 10;

to

my $MAX_LXC_NETWORKS = 32;

As far as I can see, that is enough.

Would you please consider raising the limit? Would you like me to send 
in a patch file or pull request.

Or is the above sufficient.

Thanks and kind regards,

Stephan




             reply	other threads:[~2020-08-22 21:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-22 21:41 Stephan Leemburg [this message]
2020-08-22 22:16 ` Stephan Leemburg
2020-08-23  5:03 ` Dietmar Maurer
2020-08-23  5:10   ` Dietmar Maurer
2020-08-23 10:58     ` Stephan Leemburg
2020-08-23 14:24       ` Dietmar Maurer
2020-08-23 15:04         ` Stephan Leemburg
2020-08-23 16:14           ` Stephan Leemburg
2020-08-24  4:53             ` Dietmar Maurer
2020-08-24 10:54               ` Stephan Leemburg
2020-08-24 15:49                 ` Dietmar Maurer
2020-08-24 16:14                   ` Tom Weber
2020-08-24 22:09                     ` Stephan Leemburg
2020-08-27 11:19                     ` Thomas Lamprecht
2020-08-23 15:49         ` Stephan Leemburg
2020-08-23 16:13       ` Tom Weber
2020-08-23 16:35         ` Stephan Leemburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c75d3b-88e6-36db-9c05-88254a305d4a@it-functions.nl \
    --to=sleemburg@it-functions.nl \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal