From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool
Date: Thu, 11 Jul 2024 13:31:12 +0200 [thread overview]
Message-ID: <d464b77b-87df-4a8c-8933-9230b32874be@proxmox.com> (raw)
In-Reply-To: <20240711095641.369504-1-c.heiss@proxmox.com>
gave it a test on a VM with the GUI installer.
consider this series:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2024-07-11 11:56, Christoph Heiss wrote:
> Pretty straight forward overall, implements a check for an existing
> `rpool` on the system and ask the user whether they would like to rename
> it, much in the same way as it works for VGs already.
>
> Without this, the installer would silently create a second (and thus
> conflicting) `rpool` and cause a boot failure after the installation,
> since it does not know which pool to import exactly.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html
>
> Notable changes v1 -> v2:
> * incorporated Aaron suggestions from v1
> * rewrote tests to use a pre-defined input instead
> * moved pool renaming to own subroutine
> * documented all new subroutines
> * split out tests into own patch
>
> Christoph Heiss (3):
> proxmox: add zfs module for retrieving importable zpool info
> test: add test cases for new zfs module
> low-level: install: check for already-existing `rpool` on install
>
> Proxmox/Install.pm | 30 +++++++++++
> Proxmox/Makefile | 1 +
> Proxmox/Sys/ZFS.pm | 109 ++++++++++++++++++++++++++++++++++++++
> test/Makefile | 7 ++-
> test/zfs-get-pool-list.pl | 57 ++++++++++++++++++++
> 5 files changed, 203 insertions(+), 1 deletion(-)
> create mode 100644 Proxmox/Sys/ZFS.pm
> create mode 100755 test/zfs-get-pool-list.pl
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-11 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 9:56 Christoph Heiss
2024-07-11 9:56 ` [pve-devel] [PATCH installer v2 1/3] proxmox: add zfs module for retrieving importable zpool info Christoph Heiss
2024-07-11 9:56 ` [pve-devel] [PATCH installer v2 2/3] test: add test cases for new zfs module Christoph Heiss
2024-07-11 9:56 ` [pve-devel] [PATCH installer v2 3/3] low-level: install: check for already-existing `rpool` on install Christoph Heiss
2024-07-11 11:31 ` Aaron Lauterer [this message]
2024-07-11 12:00 ` [pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d464b77b-87df-4a8c-8933-9230b32874be@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox