Re: [pve-devel] [Typo corrected. 2/2] Split a long sentence and corrected some typos.

[Fiona Ebner <f.ebner@proxmox.com>]

If you send another version of a patch series, please use the
"-v <n>, --reroll-count=<n>" option for "git format-patch".

As long as you are working on a series, you can "change history" on your
local branch. This can be done with "git rebase -i" and "git commit
--amend" and (there are also things like "git absorb"), there are plenty
tutorials on the web.

For the patch at hand, you could fold this change into the previous
patch with "--amend" and just send out the corrected patch by itself and...

Am 17.12.24 um 11:11 schrieb Alexander Abraham:
> ---

...for the corrected patch, put a changelog down here and in the cover
letter.

By prettying up your local git history, the patches will be easier to
review and when applied for real on the shared master branch, the
history will be nice to read :)

Not related to this series and depends on the situations, just
mentioning as a general hint: often one runs into problems during
development, and they might then be missing from the "clean" git
history. It's often worth mentioning those in commit messages, so they
still become a part of history.

>  local-zfs.adoc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/local-zfs.adoc b/local-zfs.adoc
> index bcd02f7..b662233 100644
> --- a/local-zfs.adoc
> +++ b/local-zfs.adoc
> @@ -627,7 +627,8 @@ You *must reboot* to activate these changes.
>  SWAP on ZFS
>  ~~~~~~~~~~~
>  
> -It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks freezing thge affected system and other unpredictable behavior. The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns against using a ZFS volume for a swap partition.
> +It is strongly recommended to not use a ZFS volume for a swap partition because this could lead to deadlocks. These deadlocks could cause the affected system to freeze. 
> +The OpenZFS documentation, which can be viewed https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux[here], warns about using a ZFS volume for a swap partition.
>  
>  [[zfs_encryption]]
>  Encrypted ZFS Datasets



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel