From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v5 manager] fix #2745: allow specifying remove parameter for manual backup
Date: Thu, 17 Jun 2021 18:00:00 +0200 [thread overview]
Message-ID: <d3b3c4d0-12d4-8267-03a6-115ffa91fdb5@proxmox.com> (raw)
In-Reply-To: <20210506121632.8417-1-f.ebner@proxmox.com>
On 06.05.21 14:16, Fabian Ebner wrote:
> Changes from v4:
> * dropped already applied patches
> * added a few small follow-ups and preparation:
> * set loading mask early enough
> * switch to two-column layout
> * changes for the main patch:
> * fix labels and gettext usage
> * only show retention settings when prune checkbox is set
>
> Fabian Ebner (6):
> ui: backup window: avoid issuing API call with null/empty parameter
> ui: backup window: also set initialDefaults variable in failure case
> ui: backup window: set loading mask early enough
> ui: backup window: switch to proxmox input panel
> ui: backup window: switch to two-column layout
> fix #2745: ui: backup window: allow specifying remove parameter for
> manual backup
>
> www/manager6/window/Backup.js | 124 ++++++++++++++++++++++++++++++----
> 1 file changed, 112 insertions(+), 12 deletions(-)
>
applied series, thanks!
Added a label for the retention settings to ensure the user knows that they come from
the storage. Also added a log line about what actual retention keep-settings are used,
as else I could not be determined in the task-log if they came from a storage or node
vzdump.conf.
prev parent reply other threads:[~2021-06-17 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 12:16 [pve-devel] " Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 1/6] ui: backup window: avoid issuing API call with null/empty parameter Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 2/6] ui: backup window: also set initialDefaults variable in failure case Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 3/6] ui: backup window: set loading mask early enough Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 4/6] ui: backup window: switch to proxmox input panel Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 5/6] ui: backup window: switch to two-column layout Fabian Ebner
2021-05-06 12:16 ` [pve-devel] [PATCH v5 manager 6/6] fix #2745: ui: backup window: allow specifying remove parameter for manual backup Fabian Ebner
2021-05-07 6:56 ` [pve-devel] [PATCH v5 manager 7/7] ui: backup window: also reset removal fields when defaults API call fails Fabian Ebner
2021-06-17 16:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b3c4d0-12d4-8267-03a6-115ffa91fdb5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox