public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v5 manager] ui: storage backup view: add prune window
Date: Tue, 24 Nov 2020 14:28:46 +0100	[thread overview]
Message-ID: <d370c59d-5e6a-4e7f-eaea-976c4d98afc5@proxmox.com> (raw)
In-Reply-To: <20201124130053.10494-1-f.ebner@proxmox.com>

On 24.11.20 14:00, Fabian Ebner wrote:
> adapted from PBS. Main differences are:
>     * API has GET/DELETE distinction instead of 'dry-run'
>     * API expects a single property string for the prune options
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Needs a dependency bump for proxmox-widget-toolkit.
> 
> Changes from v4:
>     * Switch to widget toolkit's prune keep fields.
>     * Don't load values from the storage initially. While it could be done,
>       doing a manual prune doesn't need to have to do anything at all with the
>       configuration on the storage. Problem is also that a clear trigger
>       would reset to that value instead of clearing, which obviously makes
>       sense when editing the storage configuration, but not really for
>       doing a one-shot prune operation.
>     * Use "renamed" as a reason instead of "strange name" for renamed backups
> 
>  www/manager6/Makefile              |   1 +
>  www/manager6/storage/BackupView.js |  51 ++++++
>  www/manager6/window/Prune.js       | 257 +++++++++++++++++++++++++++++
>  3 files changed, 309 insertions(+)
>  create mode 100644 www/manager6/window/Prune.js
> 
>

applied, thanks!




      reply	other threads:[~2020-11-24 13:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 13:00 [pve-devel] " Fabian Ebner
2020-11-24 13:28 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d370c59d-5e6a-4e7f-eaea-976c4d98afc5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal