[pve-devel] [PATCH manager] fix #5734: provide missing methods for Proxmox.Utils for mobile ui

[pve-devel] [PATCH manager] fix #5734: provide missing methods for Proxmox.Utils for mobile ui

[Dominik Csapak]

since the mobile ui shares the Utils code with the desktop web ui, (but
not the proxmox-widget-toolkit) all methods used in constructors, etc.
there must be available in the mobile ui too.

We don't have any notification configuration options in the mobile ui,
and AFAIK we don't plan to add those there, so we can just implement
stub functions. This way the Utils constructor can proceed without
errors, fixing loading the mobile ui.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/mobile/WidgetToolkitUtils.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/www/mobile/WidgetToolkitUtils.js b/www/mobile/WidgetToolkitUtils.js
index b292fcd5..ea710faf 100644
--- a/www/mobile/WidgetToolkitUtils.js
+++ b/www/mobile/WidgetToolkitUtils.js
@@ -586,6 +586,15 @@ utilities: {
 	}
     },
 
+    overrideNotificationFieldName: function(extra) {
+	// do nothing, we don't have notification configuration in mobile ui
+    },
+
+    overrideNotificationFieldValue: function(extra) {
+	// do nothing, we don't have notification configuration in mobile ui
+    },
+
+
     format_task_description: function(type, id) {
 	let farray = Proxmox.Utils.task_desc_table[type];
 	let text;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix #5734: provide missing methods for Proxmox.Utils for mobile ui

[Thomas Lamprecht]

Am 23/09/2024 um 12:33 schrieb Dominik Csapak:
> since the mobile ui shares the Utils code with the desktop web ui, (but
> not the proxmox-widget-toolkit) all methods used in constructors, etc.
> there must be available in the mobile ui too.
> 
> We don't have any notification configuration options in the mobile ui,
> and AFAIK we don't plan to add those there, so we can just implement
> stub functions. This way the Utils constructor can proceed without
> errors, fixing loading the mobile ui.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/mobile/WidgetToolkitUtils.js | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel