public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #5734: provide missing methods for Proxmox.Utils for mobile ui
Date: Wed, 25 Sep 2024 14:49:59 +0200	[thread overview]
Message-ID: <d35f269e-604b-4681-bc35-2bd158c2e28f@proxmox.com> (raw)
In-Reply-To: <20240923103331.1508338-1-d.csapak@proxmox.com>

Am 23/09/2024 um 12:33 schrieb Dominik Csapak:
> since the mobile ui shares the Utils code with the desktop web ui, (but
> not the proxmox-widget-toolkit) all methods used in constructors, etc.
> there must be available in the mobile ui too.
> 
> We don't have any notification configuration options in the mobile ui,
> and AFAIK we don't plan to add those there, so we can just implement
> stub functions. This way the Utils constructor can proceed without
> errors, fixing loading the mobile ui.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/mobile/WidgetToolkitUtils.js | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-09-25 12:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 10:33 [pve-devel] " Dominik Csapak
2024-09-25 12:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d35f269e-604b-4681-bc35-2bd158c2e28f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal