From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix: make 'ceph-volume' conditional on quincy install
Date: Mon, 4 Jul 2022 17:25:06 +0200 [thread overview]
Message-ID: <d3126087-590e-7f0d-0db8-06788322606b@proxmox.com> (raw)
In-Reply-To: <20220704150543.523740-1-s.sterz@proxmox.com>
With pve-manager 7.2-6, installing pacific will fail very qickly, as the package
'ceph-volume' cannot be found.
Tested this patch by installing pacific and quincy.
One comment inline
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 7/4/22 17:05, Stefan Sterz wrote:
> when installing non-quincy versions, 'ceph-volume' is not contained in
> the respective repositories and, thus, the install process would fail.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> tested this by installing ceph pacific and quincy, but my setup wasn't
> really clean so i ran into some unrelated issues.
>
> PVE/CLI/pveceph.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
> index a85df130..8e6c8667 100755
> --- a/PVE/CLI/pveceph.pm
> +++ b/PVE/CLI/pveceph.pm
> @@ -176,13 +176,16 @@ __PACKAGE__->register_method ({
> my @ceph_packages = qw(
> ceph
> ceph-common
> - ceph-volume
> ceph-mds
> ceph-fuse
> gdisk
> nvme-cli
> );
>
> + if ($cephver eq 'quincy') {
Wouldn't it be better to check if we are not installing octopus & pacific? Then
it will work for any newer Ceph version as well. Once we do not support octopus
and pacific anymore, we can add 'ceph-volume' unconditionally to the list of
packages to install.
> + push @ceph_packages, 'ceph-volume';
> + }
> +
> print "start installation\n";
>
> # this flag helps to determine when apt is actually done installing (vs. partial extracing)
next prev parent reply other threads:[~2022-07-04 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 15:05 Stefan Sterz
2022-07-04 15:25 ` Aaron Lauterer [this message]
2022-07-04 15:26 ` Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3126087-590e-7f0d-0db8-06788322606b@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox