Re: [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB

[Fiona Ebner <f.ebner@proxmox.com>]

Am 01.06.25 um 11:51 schrieb Thomas Lamprecht:
> Am 12.05.25 um 15:00 schrieb Fiona Ebner:
>> Am 12.05.25 um 14:41 schrieb Fiona Ebner:
>>> Maybe best is to wait for PVE 9 with this and do a parse+write for all
>>> guest configs (including their snapshots) in the pve8to9 script? The
>>> change also breaks backwards migration to a node that doesn't
>>> understand the new suffix.
>>
>> If we decide on that, I'll split the patch common 1/5 into two, since we
>> already need the parsing support in PVE 8 (or we couldn't rewrite in
>> pve8to9). And in PVE 9, we can switch to writing with the verbose
>> suffixes by default.
> 
> Saw this reply only later; yeah, please split this up and NACK form my
> side for such a rewrites in 8to9 checker script.

Ack, I'll send a v2 with only the parsing support (and the tangential
vzdump logging patch).

Regarding rewriting in pve8to9: I feel like it will be confusing to
users if there is a mix of suffixes in different guest configs. But
okay, I guess we can mention this as a known issue in the upgrade guide,
i.e. that the old suffixes for disks in guest configs meant powers of
1024 too (even if it's not an actual issue, but just ambiguity).

Alternatively, we could also add an UI patch to always display the new
suffix even if the config contains the old one?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel