From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH pve-storage] fix #3555: BTRFSPlugin: call free_image correctly
Date: Fri, 30 Jul 2021 15:06:39 +0200 [thread overview]
Message-ID: <d2c54b06-4ded-c864-66c3-a965077fff7c@proxmox.com> (raw)
In-Reply-To: <20210730110455.118306-1-h.laimer@proxmox.com>
On 30/07/2021 13:04, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks! Albeit the commit message was lacking background, so I amended
it with:
> The method is only derived in the DirPlugin module from the base
> Plugin, so we do not have it available there through a static module
> method call using ::, but only when using a class dereference.
>
> Other fix options would have been:
>
> PVE::Storage::Plugin::free_image(@_);
>
> or:
> $class->SUPER::free_image($storeid, ...);
IMO, always helpful to have some background, it can help others learn something or
jump start such lousy brains like mine if they come over this in a few months again,
maybe even want to "optimize it back"; at least that's my experience with ours and
other projects source control trees, I never thought "wow, too much related info there
in the commit message" ;-)
next prev parent reply other threads:[~2021-07-30 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 11:04 [pve-devel] " Hannes Laimer
2021-07-30 13:06 ` Thomas Lamprecht [this message]
2021-08-02 8:29 ` Fabian Ebner
2021-08-02 9:58 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c54b06-4ded-c864-66c3-a965077fff7c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox