[pve-devel] [PATCH] pve7to8: add check for systemd-boot presence where needed

[pve-devel] [PATCH] pve7to8: add check for systemd-boot presence where needed

[Stoiko Ivanov]

since the package won't get installed for systems upgraded from 7 to 8
we warn users who need systemd-boot - to be able to initialize new
ESPs - that they need to install it

The check for package installation is based on existance of the
changelog, since the package information used in pve7to8 comes from
the API-modules, which limit it to the pve-relevant packages.

tested in VMs with uefi and legacy mode, with existing
proxmox-boot-uuids both with and w/o systemd-boot being installed

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/CLI/pve7to8.pm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 29bb099d..712deb20 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -1229,6 +1229,34 @@ sub check_time_sync {
     }
 }
 
+sub check_bootloader {
+    log_info("Checking bootloader configuration...");
+    if (!$upgraded) {
+	log_skip("not yet upgraded, no need to check the presence of systemd-boot");
+	return;
+    }
+
+    if (! -f "/etc/kernel/proxmox-boot-uuids") {
+	log_skip("proxmox-boot-tool not used for bootloader configuration");
+	return;
+    }
+
+    if (! -d "/sys/firmware/efi") {
+	log_skip("System booted in legacy-mode - no need for systemd-boot");
+	return;
+    }
+
+    if ( -f "/usr/share/doc/systemd-boot/changelog.Debian.gz") {
+	log_pass("systemd-boot is installed");
+    } else {
+	log_warn(
+	    "proxmox-boot-tool is used for bootloader configuration in uefi mode"
+	    . "but the separate systemd-boot package, existing in Debian Bookworm  is not installed"
+	    . "initializing new ESPs will not work until the package is installed"
+	);
+    }
+}
+
 sub check_misc {
     print_header("MISCELLANEOUS CHECKS");
     my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') };
@@ -1328,6 +1356,7 @@ sub check_misc {
     check_lxcfs_fuse_version();
     check_node_and_guest_configurations();
     check_apt_repos();
+    check_bootloader();
 }
 
 my sub colored_if {
-- 
2.30.2

[pve-devel] applied: [PATCH] pve7to8: add check for systemd-boot presence where needed

[Thomas Lamprecht]

Am 21/06/2023 um 19:35 schrieb Stoiko Ivanov:
> since the package won't get installed for systems upgraded from 7 to 8
> we warn users who need systemd-boot - to be able to initialize new
> ESPs - that they need to install it
> 
> The check for package installation is based on existance of the
> changelog, since the package information used in pve7to8 comes from
> the API-modules, which limit it to the pve-relevant packages.
> 
> tested in VMs with uefi and legacy mode, with existing
> proxmox-boot-uuids both with and w/o systemd-boot being installed
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  PVE/CLI/pve7to8.pm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
>

applied, thanks!