[pve-devel] [PATCH pve-manager 0/1] Add MTU to NetworkEdit

[pve-devel] [PATCH pve-manager 0/1] Add MTU to NetworkEdit

[Thomas Crummett]

MTU is used in several locations within code, but there is no form in the interface to edit the value. There should be a form to edit MTU.

Thomas Crummett (1):
  Adds MTU to NetworkEdit

 www/manager6/qemu/NetworkEdit.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.32.0 (Apple Git-132)

[pve-devel] [PATCH pve-manager 1/1] Adds MTU to NetworkEdit

[Thomas Crummett]

---
 www/manager6/qemu/NetworkEdit.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..8e70e386 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -15,6 +15,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 	    me.network.bridge = values.bridge;
 	    me.network.tag = values.tag;
 	    me.network.firewall = values.firewall;
+	    me.network.mtu = values.mtu;
 	}
 	me.network.macaddr = values.macaddr;
 	me.network.disconnect = values.disconnect;
@@ -88,6 +89,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 	];
 
 	me.advancedColumn1 = [
+	    {
+		xtype: 'proxmoxintegerfield',
+		name: 'mtu',
+		fieldLabel: 'MTU',
+		minimum: 1,
+		emptyText: '1500',
+		submitEmpty: false,
+		cbind: {
+			deleteEmpty: '{!isCreate}',
+		},
+	    },
 	    {
 		xtype: 'proxmoxcheckbox',
 		fieldLabel: gettext('Disconnect'),
@@ -105,6 +117,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 		    change: function(cb, value) {
 			var fields = [
 			    'disconnect',
+			    'mtu',
 			    'bridge',
 			    'tag',
 			    'firewall',
-- 
2.32.0 (Apple Git-132)

Re: [pve-devel] [PATCH pve-manager 1/1] Adds MTU to NetworkEdit

[DERUMIER, Alexandre]

Hi,

They are already a pending patches serie here:

https://www.mail-archive.com/pve-devel@lists.proxmox.com/msg08696.html

Le 5/09/22 à 13:11, Thomas Crummett a écrit :
> ---
>   www/manager6/qemu/NetworkEdit.js | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index b39cffdc..8e70e386 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -15,6 +15,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   	    me.network.bridge = values.bridge;
>   	    me.network.tag = values.tag;
>   	    me.network.firewall = values.firewall;
> +	    me.network.mtu = values.mtu;
>   	}
>   	me.network.macaddr = values.macaddr;
>   	me.network.disconnect = values.disconnect;
> @@ -88,6 +89,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   	];
>   
>   	me.advancedColumn1 = [
> +	    {
> +		xtype: 'proxmoxintegerfield',
> +		name: 'mtu',
> +		fieldLabel: 'MTU',
> +		minimum: 1,
> +		emptyText: '1500',
> +		submitEmpty: false,
> +		cbind: {
> +			deleteEmpty: '{!isCreate}',
> +		},
> +	    },
>   	    {
>   		xtype: 'proxmoxcheckbox',
>   		fieldLabel: gettext('Disconnect'),
> @@ -105,6 +117,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   		    change: function(cb, value) {
>   			var fields = [
>   			    'disconnect',
> +			    'mtu',
>   			    'bridge',
>   			    'tag',
>   			    'firewall',