* [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address
@ 2023-06-21 10:46 Stefan Hanreich
2023-06-21 10:48 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2023-06-21 10:46 UTC (permalink / raw)
To: pve-devel
Currently the TUI installer reads the value for the DNS server from
the field for the gateway.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-tui-installer/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
index 510807a..77818e7 100644
--- a/proxmox-tui-installer/src/main.rs
+++ b/proxmox-tui-installer/src/main.rs
@@ -540,7 +540,7 @@ fn network_dialog(siv: &mut Cursive) -> InstallerView {
.map_err(|err| err.to_string())?;
let dns_server = view
- .get_value::<EditView, _>(3)
+ .get_value::<EditView, _>(4)
.ok_or("failed to retrieve DNS server address")?
.parse::<IpAddr>()
.map_err(|err| err.to_string())?;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address
2023-06-21 10:46 [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address Stefan Hanreich
@ 2023-06-21 10:48 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-21 10:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Stefan Hanreich
Am 21/06/2023 um 12:46 schrieb Stefan Hanreich:
> Currently the TUI installer reads the value for the DNS server from
> the field for the gateway.
>
Many thanks for the patch-as-report approach, but Christoph already provided
this one after I noticed it off-list, and I pushed that (looks exactly the same)
already; sorry!
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> proxmox-tui-installer/src/main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
> index 510807a..77818e7 100644
> --- a/proxmox-tui-installer/src/main.rs
> +++ b/proxmox-tui-installer/src/main.rs
> @@ -540,7 +540,7 @@ fn network_dialog(siv: &mut Cursive) -> InstallerView {
> .map_err(|err| err.to_string())?;
>
> let dns_server = view
> - .get_value::<EditView, _>(3)
> + .get_value::<EditView, _>(4)
> .ok_or("failed to retrieve DNS server address")?
> .parse::<IpAddr>()
> .map_err(|err| err.to_string())?;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-21 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-21 10:46 [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address Stefan Hanreich
2023-06-21 10:48 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox