From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-installer] tui: read correct input for DNS server address
Date: Wed, 21 Jun 2023 12:48:58 +0200 [thread overview]
Message-ID: <d1f716a0-841e-b836-dab0-d348f7073163@proxmox.com> (raw)
In-Reply-To: <20230621104603.257124-1-s.hanreich@proxmox.com>
Am 21/06/2023 um 12:46 schrieb Stefan Hanreich:
> Currently the TUI installer reads the value for the DNS server from
> the field for the gateway.
>
Many thanks for the patch-as-report approach, but Christoph already provided
this one after I noticed it off-list, and I pushed that (looks exactly the same)
already; sorry!
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> proxmox-tui-installer/src/main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
> index 510807a..77818e7 100644
> --- a/proxmox-tui-installer/src/main.rs
> +++ b/proxmox-tui-installer/src/main.rs
> @@ -540,7 +540,7 @@ fn network_dialog(siv: &mut Cursive) -> InstallerView {
> .map_err(|err| err.to_string())?;
>
> let dns_server = view
> - .get_value::<EditView, _>(3)
> + .get_value::<EditView, _>(4)
> .ok_or("failed to retrieve DNS server address")?
> .parse::<IpAddr>()
> .map_err(|err| err.to_string())?;
prev parent reply other threads:[~2023-06-21 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 10:46 Stefan Hanreich
2023-06-21 10:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1f716a0-841e-b836-dab0-d348f7073163@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox