From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 3/3] ui: GuestStatusView: add 'privileged' and 'ostype' fields
Date: Wed, 7 Jun 2023 13:49:16 +0200 [thread overview]
Message-ID: <d19746ca-8bd9-4d26-1e52-fd47591254f1@proxmox.com> (raw)
In-Reply-To: <20230503095042.137966-4-c.heiss@proxmox.com>
Am 03/05/2023 um 11:50 schrieb Christoph Heiss:
> The privileged status is displayed by adding a new row to the status
> panel, while the distribution logo and name are displayed on the right
> side of the title bar of the status panel. The latter fits neatly there,
> is rather unintrusive and yet still visible at first sight.
>
> This also solves the problem of having to create a bigger row, so that
> the icon is still easily recognisable. At the default font-size of
> 13pt, this really wasn't the case.
>
> I verified that each supported distro is present in the font and the
> name matches up and tested through all supported distros (including
> 'unmanaged').
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> www/manager6/panel/GuestStatusView.js | 51 ++++++++++++++++++++++++++-
> 1 file changed, 50 insertions(+), 1 deletion(-)
>
please split this patch up, this is adding two relatively unrelated things.
prev parent reply other threads:[~2023-06-07 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:50 [pve-devel] [PATCH manager 0/3] fix #2435: lxc: show distro and privileged status in summary Christoph Heiss
2023-05-03 9:50 ` [pve-devel] [PATCH manager 1/3] ui: clean up remnants of in-tree font-awesome files Christoph Heiss
2023-06-07 10:15 ` [pve-devel] applied: " Thomas Lamprecht
2023-05-03 9:50 ` [pve-devel] [PATCH manager 2/3] ui: add 'font-logos' stylesheet and font files Christoph Heiss
2023-06-07 10:59 ` Thomas Lamprecht
2023-06-09 9:28 ` Christoph Heiss
2023-05-03 9:50 ` [pve-devel] [PATCH manager 3/3] ui: GuestStatusView: add 'privileged' and 'ostype' fields Christoph Heiss
2023-06-07 11:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19746ca-8bd9-4d26-1e52-fd47591254f1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox