From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #3182 #3183: change backup retention mask logic
Date: Wed, 2 Dec 2020 18:04:40 +0100 [thread overview]
Message-ID: <d19648bf-76be-a92b-9201-aa261ff0a9fe@proxmox.com> (raw)
In-Reply-To: <20201202125631.19336-1-d.csapak@proxmox.com>
On 02.12.20 13:56, Dominik Csapak wrote:
> instead of relying on the contentTypeField (which does not need to
> exists, e.g. for iscsi), explicitely write it into the panel/icon
> mapping and check that
>
> better would be if we query the backend about storage capabilities,
> but such an api call does not exist yet, so this should be ok for now
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/Utils.js | 41 +++++++++++++++++++++++-----------
> www/manager6/dc/StorageView.js | 1 +
> www/manager6/storage/Base.js | 3 +--
> 3 files changed, 30 insertions(+), 15 deletions(-)
>
>
I gave it some thought to finally start the storage schema/capabilities API
endpoint we often talked about, but I did not want to rush it and this is
way less complicated for now..
applied, thanks!
prev parent reply other threads:[~2020-12-02 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:56 [pve-devel] " Dominik Csapak
2020-12-02 13:11 ` Thomas Lamprecht
2020-12-02 13:19 ` Dominik Csapak
2020-12-02 13:27 ` Thomas Lamprecht
2020-12-02 17:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19648bf-76be-a92b-9201-aa261ff0a9fe@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox