From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/5] ui: vm: factor out async I/O type selector
Date: Fri, 18 Oct 2024 09:42:27 +0200 [thread overview]
Message-ID: <d11f0260-7635-451f-b474-64552146e477@proxmox.com> (raw)
In-Reply-To: <20241016164711.934544-3-d.kral@proxmox.com>
Hello, one comment inline.
Skimmed over the code to spot style issues, correctness
was not really checked.
On 2024-10-16 18:47, Daniel Kral wrote:
> Factors out the combo box used for the Async I/O combo box selector,
> which is used in the Disk Edit modal window in the VM "Hardware" tab and
> the "Disks" tab in the Create Wizard, to reuse it in a future commit.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> www/manager6/Makefile | 1 +
> www/manager6/form/AsyncIOTypeSelector.js | 10 ++++++++++
> www/manager6/qemu/HDEdit.js | 10 ++--------
> 3 files changed, 13 insertions(+), 8 deletions(-)
> create mode 100644 www/manager6/form/AsyncIOTypeSelector.js
>
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index 2c3a822b..74a61aa8 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -21,6 +21,7 @@ JSSRC= \
> form/ACMEAccountSelector.js \
> form/ACMEPluginSelector.js \
> form/AgentFeatureSelector.js \
> + form/AsyncIOTypeSelector.js \
> form/BackupCompressionSelector.js \
> form/BackupModeSelector.js \
> form/BandwidthSelector.js \
> diff --git a/www/manager6/form/AsyncIOTypeSelector.js b/www/manager6/form/AsyncIOTypeSelector.js
> new file mode 100644
> index 00000000..83fb40b5
> --- /dev/null
> +++ b/www/manager6/form/AsyncIOTypeSelector.js
> @@ -0,0 +1,10 @@
> +Ext.define('PVE.form.AsyncIOTypeSelector', {
> + extend: 'Proxmox.form.KVComboBox',
> + alias: ['widget.AsyncIOTypeSelector'],
Usually we use a prefix `pve` (for components defined in pve-manager) or `pmx`
(for components defined in proxmox-widget-toolkit`) prefix, so this
should be `widget.pveAsyncIoTypeSelector`
> + comboItems: [
> + ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'],
> + ['io_uring', 'io_uring'],
> + ['native', 'native'],
> + ['threads', 'threads'],
> + ],
> +});
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index b78647ec..37215361 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -306,17 +306,11 @@ Ext.define('PVE.qemu.HDInputPanel', {
> name: 'noreplicate',
> },
> {
> - xtype: 'proxmoxKVComboBox',
> + xtype: 'AsyncIOTypeSelector',
> name: 'aio',
> + value: '__default__',
> fieldLabel: gettext('Async IO'),
> allowBlank: false,
> - value: '__default__',
> - comboItems: [
> - ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'],
> - ['io_uring', 'io_uring'],
> - ['native', 'native'],
> - ['threads', 'threads'],
> - ],
> },
> );
>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-18 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 16:47 [pve-devel] [PATCH kernel/manager 0/5] fix #5430: ocfs2 io_uring read Daniel Kral
2024-10-16 16:47 ` [pve-devel] [PATCH kernel 1/5] fix #5430: cherry-pick fix for ocfs2 io_uring rw issues Daniel Kral
2024-10-17 14:48 ` Friedrich Weber
2024-10-22 14:03 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-16 16:47 ` [pve-devel] [PATCH manager 2/5] ui: vm: factor out async I/O type selector Daniel Kral
2024-10-18 7:42 ` Lukas Wagner [this message]
2024-10-16 16:47 ` [pve-devel] [PATCH manager 3/5] fix #5430: ui: vm: allow editing cdrom aio and cache options Daniel Kral
2024-10-18 7:42 ` Lukas Wagner
2024-10-23 11:30 ` Daniel Kral
2024-10-16 16:47 ` [pve-devel] [PATCH manager 4/5] ui: vm: make cloudinit drive editable Daniel Kral
2024-10-18 7:42 ` Lukas Wagner
2024-10-16 16:47 ` [pve-devel] [PATCH manager 5/5] fix #5430: ui: vm: allow editing cloudinit aio and cache options Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d11f0260-7635-451f-b474-64552146e477@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox