From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 installer 1/1] fix #4643: show a confirmation dialog when clicking abort
Date: Wed, 21 Jun 2023 12:30:00 +0200 [thread overview]
Message-ID: <d10afce4-f6da-7805-b78c-2437e42dc129@proxmox.com> (raw)
In-Reply-To: <20230621085505.28910-2-m.sandoval@proxmox.com>
Am 21/06/2023 um 10:55 schrieb Maximiliano Sandoval:
> Note that unlike the rest of the file, we connect to the response signal
> instead of using Gtk3::Dialog->run, the reason is that run blocks the
> main loop used by GTK and this undesirable to the point where
> Gtk3::Dialog->run was removed for GTK 4.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxinstall | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-21 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:55 [pve-devel] [PATCH v2 installer 0/1] " Maximiliano Sandoval
2023-06-21 8:55 ` [pve-devel] [PATCH v2 installer 1/1] " Maximiliano Sandoval
2023-06-21 10:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d10afce4-f6da-7805-b78c-2437e42dc129@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox