Re: [pve-devel] [PATCH container 3/4] add 'pbs-entries-max' parameter

[Fiona Ebner <f.ebner@proxmox.com>]

Am 13.06.23 um 15:42 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  src/PVE/VZDump/LXC.pm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
> index 5783ffa..a1d2ec8 100644
> --- a/src/PVE/VZDump/LXC.pm
> +++ b/src/PVE/VZDump/LXC.pm
> @@ -395,6 +395,11 @@ sub archive {
>  	push @$param, '--backup-id', $vmid;
>  	push @$param, '--backup-time', $task->{backup_time};
>  
> +	if ($opts->{"pbs-entries-max"}) {
> +		push @$param, '--entries-max', $opts->{"pbs-entries-max"};
> +		$self->loginfo("override max number of entries to hold in memory");
Style nit: wrong indentation.

I'd also include the new value in the log line. And maybe replacing "to
hold in memory" with "for file-based backup" makes it easier to grasp
from a user perspective?

> +	}
> +
>  	my @storage = ($opts->{scfg}, $opts->{storage});
>  
>  	my $logfunc = sub { my $line = shift; $self->loginfo($line) };