From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression
Date: Wed, 27 Sep 2023 10:57:09 +0200 [thread overview]
Message-ID: <d0e67a78-5ddb-2aef-42fc-902c02320053@proxmox.com> (raw)
In-Reply-To: <2359ccf4-f8f8-479f-8a24-b6a76ad950a5@proxmox.com>
On 9/27/23 10:33, Thomas Lamprecht wrote:
> Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl:
>>> There are code paths where $filename is not yet defined here, resulting
>>> in a rather ugly warning – so this needs upfront checking too – always
>>> check where the value code path is coming in (yeah, Rust would do that for
>>> you, but most API endpoints are small enough to be able to do so quickly also manually)
>>
>> I will make a new patch resolving this issue. While I am on it, I see
>> what I can resolve on the other issues.
>
> FYI, I have a pretty much done patch for this already here, so if
> you did not have anything (close to) already finished, I could push
> that out – just mentioning to avoid potential duplicate work.
I have nothing close. Sorry for the inconvenience and thank you for
fixing.
next prev parent reply other threads:[~2023-09-27 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 13:09 [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs Philipp Hufnagl
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-09-26 10:56 ` Thomas Lamprecht
2023-09-26 12:25 ` Philipp Hufnagl
2023-09-26 14:23 ` Thomas Lamprecht
2023-09-26 14:54 ` Philipp Hufnagl
2023-09-26 14:57 ` Thomas Lamprecht
2023-09-27 8:03 ` Philipp Hufnagl
2023-09-27 8:33 ` Thomas Lamprecht
2023-09-27 8:57 ` Philipp Hufnagl [this message]
2023-09-27 17:19 ` Thomas Lamprecht
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: " Philipp Hufnagl
2023-09-26 10:59 ` Thomas Lamprecht
2023-09-26 12:27 ` Philipp Hufnagl
2023-09-22 14:02 ` [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs Dominik Csapak
2023-09-26 7:39 ` [pve-devel] applied-series: [PATCH manager v9 " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e67a78-5ddb-2aef-42fc-902c02320053@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox