From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH http-server v2 1/2] upload: allow whitespaces in filenames
Date: Mon, 7 Nov 2022 16:42:42 +0100 [thread overview]
Message-ID: <d0b0a14c-cf4e-8aad-833e-de3f7c1dbde7@proxmox.com> (raw)
In-Reply-To: <20221107150750.2320248-1-d.csapak@proxmox.com>
Am 07/11/2022 um 16:07 schrieb Dominik Csapak:
> some fields (e.g. filename) can contain spaces, but our 'trim' function,
> would only return the value until the first whitespace character instead
> of removing leading/trailing white space. this lead to giving the wrong
> filename to the api call (e.g. 'foo' instead of 'foo (1).iso') which
> would reject it because of the 'wrong' extension
>
> this patch fixes that by using trim from pve-common
>
> fixes commit:
> 0fbcbc2 ("fix #3990: multipart upload: rework to fix uploading small files")
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/APIServer/AnyEvent.pm | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-11-07 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:07 [pve-devel] " Dominik Csapak
2022-11-07 15:07 ` [pve-devel] [PATCH http-server v2 2/2] remove dead code 'parse_content_disposition' Dominik Csapak
2022-11-07 15:42 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-07 15:42 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b0a14c-cf4e-8aad-833e-de3f7c1dbde7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox