From: Markus Frank <m.frank@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard
Date: Fri, 14 Jul 2023 10:27:47 +0200 [thread overview]
Message-ID: <d079e235-48ff-084b-641c-67968571c877@proxmox.com> (raw)
In-Reply-To: <20230522100949.80363-1-m.frank@proxmox.com>
ping
On 5/22/23 12:09, Markus Frank wrote:
> overall changes v9:
> * renamed vnc_clipboard to vnc-clipboard
>
>
> qemu-server:
>
> changes v8:
> * removed unnecessary conditions
> * removed spicedevices variable and changed back to devices
> * created is_spice variable
>
> changes v6:
> * added check if vga->type is set to prevent error when using default display
> * renamed clipboard to vnc_clipboard
>
> changes v5:
> * removed return of regex check in the assertion-function for the clipboard config
> * moved clipboard code into spice-if-block
>
> changes v4:
> * removed duplicate code and created a spicedevices variable to store
> spice/vdagent devices.
> * clipboard_check_compatibility function
>
> changes v3:
> * added hint to make clearer that the spice guest tools are required for
> the noVNC-clipboard
> * Checkbox changes to ComboBox when a spice device is selected to make
> clear that only one clipboard can be used at a time.
> * added 2 test-cases
>
> changes v2:
> * added pci address to virtio-serial-pci
>
> Markus Frank (2):
> enable clipboard parameter in vga_fmt
> test cases for clipboard spice & std
>
> PVE/API2/Qemu.pm | 13 +++++
> PVE/QemuServer.pm | 61 ++++++++++++++++-------
> test/cfg2cmd/VNC-clipboard-spice.conf | 1 +
> test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 ++++++++++
> test/cfg2cmd/VNC-clipboard-std.conf | 1 +
> test/cfg2cmd/VNC-clipboard-std.conf.cmd | 27 ++++++++++
> 6 files changed, 111 insertions(+), 19 deletions(-)
> create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf
> create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf.cmd
> create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf
> create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf.cmd
>
>
> novnc-pve:
>
> Markus Frank (1):
> added show clipboard button patch to series
>
> .../patches/0019-show-clipboard-button.patch | 30 +++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 31 insertions(+)
> create mode 100644 debian/patches/0019-show-clipboard-button.patch
>
>
> pve-manager:
>
> change v7:
> * fixed the empty Display Bug in VGA options found by Friedrich
> (it should be "Default" instead of empty)
>
> changes v6:
> * Changed onGetValues in DisplayEdit to only set the saved vnc_clipboard
> variable, so it's possible to reset type and memory to default values
>
> changes v4:
> * moved clipboard option from Display settings in Hardware to Options
>
> Markus Frank (1):
> added clipboard checkbox to VM Options
>
> www/manager6/qemu/DisplayEdit.js | 8 +++++++
> www/manager6/qemu/Options.js | 37 ++++++++++++++++++++++++++++++++
> 2 files changed, 45 insertions(+)
>
>
> pve-docs:
>
> changes v4:
> * rewrote entire Text
> * added command example to set clipboard to 1
>
> Markus Frank (1):
> added noVNC clipboard documentation
>
> qm.adoc | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
prev parent reply other threads:[~2023-07-14 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:09 Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH qemu-server v9 1/5] enable VNC clipboard parameter in vga_fmt Markus Frank
2023-08-21 14:05 ` Fiona Ebner
2023-05-22 10:09 ` [pve-devel] [PATCH qemu-server v9 2/5] test cases for clipboard spice & std Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH novnc v9 3/5] added show clipboard button patch to series Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH manager v9 4/5] added clipboard checkbox to VM Options Markus Frank
2023-05-22 10:09 ` [pve-devel] [PATCH docs v9 5/5] added noVNC clipboard documentation Markus Frank
2023-06-15 12:11 ` [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard Dominik Csapak
2023-07-17 13:50 ` Thomas Lamprecht
2023-07-14 8:27 ` Markus Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d079e235-48ff-084b-641c-67968571c877@proxmox.com \
--to=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox