public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-kernel] add patch: vhost: bump max_mem_regions to 509
Date: Mon, 16 Nov 2020 11:25:48 +0100	[thread overview]
Message-ID: <d02a361f-1e5b-3340-77ad-178a6e042dec@proxmox.com> (raw)
In-Reply-To: <20201115183609.3022395-1-aderumier@odiso.com>

On 15.11.20 19:36, Alexandre Derumier wrote:
> Currently, default value is 64, so qemu is limited to 64 hotplug dimm
> 
> original patch from 2015
> https://patchwork.kernel.org/project/kvm/patch/1438180163-275465-3-git-send-email-imammedo@redhat.com/
> 
> We have discusted about this in 2016 (At this time some optimisations patches were missing)
> https://lists.proxmox.com/pipermail/pve-devel/2016-December/024502.html
> 

What is wrong with setting it as module option?
https://lists.proxmox.com/pipermail/pve-devel/2016-December/024508.html

> Also, this fix this bugzilla
> https://bugzilla.proxmox.com/show_bug.cgi?id=1426
> 
> Wolfgang proposed to have explicit dimm module management, it could be great,
> but for now this patch is fixed the current implemlentation.
> 
> 

maybe Stefan gets around to make this all a nicer approach?

https://lists.proxmox.com/pipermail/pve-devel/2016-December/024519.html

> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  ...08-vhost-bump-max_mem_regions-to-509.patch | 32 +++++++++++++++++++
>  submodules/ubuntu-focal                       |  2 +-
>  2 files changed, 33 insertions(+), 1 deletion(-)
>  create mode 100644 patches/kernel/0008-vhost-bump-max_mem_regions-to-509.patch
snip
> diff --git a/submodules/ubuntu-focal b/submodules/ubuntu-focal
> index fd386a6..721ac24 160000
> --- a/submodules/ubuntu-focal
> +++ b/submodules/ubuntu-focal
> @@ -1 +1 @@
> -Subproject commit fd386a64a1ed3f2f047318508ebd733f56a4fab2
> +Subproject commit 721ac248403a4c7ea98c416fc28f22c0bfbbb63d
> 

above hunk for the submodule shouldn't be included in the patch, it refers to
a git object which is not in ubuntus tree, probably only local in your working
tree.





  parent reply	other threads:[~2020-11-16 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 18:36 Alexandre Derumier
2020-11-16  6:38 ` Alexandre Derumier
2020-11-16 10:25 ` Thomas Lamprecht [this message]
2020-11-17 10:53   ` Alexandre Derumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d02a361f-1e5b-3340-77ad-178a6e042dec@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal