Re: [pve-devel] [PATCH pve-manager] postinst: Filter RADOS block devices

[Friedrich Weber <f.weber@proxmox.com>]

Already discussed with Stefan off-list yesterday, posting here for the
record:

There is one problem when upgrading from < 8.1.4 with a custom LVM
config where global_filter spans multiple lines, e.g.:

devices {
     # added by pve-manager to avoid scanning ZFS zvols
     global_filter=["r|/dev/zd.*|",
		"r|/dev/foobar|"]
}

With the patch, this is rewritten but only the first line is commented out:

devices {
     # added by pve-manager to avoid scanning ZFS zvols
#     global_filter=["r|/dev/zd.*|",
		"r|/dev/foobar|"]
 }
devices {
     # added by pve-manager to avoid scanning ZFS zvols and RADOS block
devices
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]
 }

And LVM doesn't like this:

# lvs
Parse error at byte 111808 (line 2453): unexpected token
  Failed to load config file /etc/lvm/lvm.conf

Not sure how we could extend the global_filter in a reliable way if it
is customized ... worst case, it might be an option to only rewrite the
LVM config if it is unchanged (plus our ZFS zvol addition), and leave
custom configs alone (and add a hint in the upgrade guide)?