public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager 0/3] watchdog: sync log to disk before and after expiring
Date: Mon, 16 Jun 2025 10:40:48 +0200	[thread overview]
Message-ID: <ce398d7b-3925-4123-9a09-ffd5be0f94c3@proxmox.com> (raw)
In-Reply-To: <20250519130935.365142-1-m.sandoval@proxmox.com>

tested it by applying this series to a node with HA guests and then 
disabling the corosync network completely or, to test the "averted" log, 
sleeping for 45 seconds before bringing the corosync network back up.

So far, it seems that the "about to expire" warning did make it into the 
journal in my tests.

We will see in the future, how well that will work in production 
systems, depending on the underlying storage layer.


Some smaller remarks on patch 2/3.

Considers this series:
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>



On  2025-05-19  15:09, Maximiliano Sandoval wrote:
> It is very hard to provide a definitive answer to whether a host fenced or not.
> In some cases the journal on the disk can be missing up to 2 minutes since its
> last logged entry and the time where another node detects the corosync link is
> down, with such a gap, the fenced node would not even record that it lost
> conenction and it is not possible to fully-determine if the node was fenced or
> not.
> 
> This series:
>   - adds a second warning 10 seconds before the watchdog expires
>   - syncs the journal to disk after the warning was issued
>   - syncs the journal to disk after the watchdog expires
> 
> The variable names in the second commit could use some feedback. The way the
> warning timeout is defined was arbitrary (10 seconds before the fence).
> 
> Maximiliano Sandoval (3):
>    watchdog: separate if in two parts
>    watchdog: warn when about to expire
>    watchdog: sync journal after sending expiration related messages
> 
>   src/watchdog-mux.c | 40 +++++++++++++++++++++++++++++++++-------
>   1 file changed, 33 insertions(+), 7 deletions(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-06-16  8:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 13:09 Maximiliano Sandoval
2025-05-19 13:09 ` [pve-devel] [PATCH ha-manager 1/3] watchdog: separate if in two parts Maximiliano Sandoval
2025-05-19 13:09 ` [pve-devel] [PATCH ha-manager 2/3] watchdog: warn when about to expire Maximiliano Sandoval
2025-06-16  8:37   ` Aaron Lauterer
2025-06-17  6:11   ` Thomas Lamprecht
2025-05-19 13:09 ` [pve-devel] [PATCH ha-manager 3/3] watchdog: sync journal after sending expiration related messages Maximiliano Sandoval
2025-06-17  6:21   ` Thomas Lamprecht
2025-07-04 12:32     ` Maximiliano Sandoval
2025-06-16  8:40 ` Aaron Lauterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce398d7b-3925-4123-9a09-ffd5be0f94c3@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal