public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu-server/docs v3] disable S3/S4 power states by default
Date: Sun, 6 Apr 2025 19:46:10 +0200	[thread overview]
Message-ID: <cd822b28-a88c-4c44-bb41-0e4129c99e8c@proxmox.com> (raw)
In-Reply-To: <20250404125345.3244659-1-d.csapak@proxmox.com>

Am 04.04.25 um 14:53 schrieb Dominik Csapak:> qemu-server:
> 
> Dominik Csapak (8):
>   tests: cfg2cmd: add test for windows machine pinning from meta info
>   config to command: get rid of globalFlags
>   machine: correctly select pve machine version for non pinned windows
>     guests
>   machine: incorporate pve machine version when pinning windows guests
>   machine: add S3/S4 power state properties
>   machine: bump pve machine version and reverse the s3/s4 defaults
>   api: qemu machine capabilities: add custom pveX versions too
>   api: qemu machine capabilities: add description for pveX variants

applied series, thanks!

Tracking the changes of PVE versions is definitively filling a missing
piece. I rework that handling a bit in a follow-up, unifying the two
hashes to avoid running out of sync and also trying to make querying it
slightly easier (e.g., no need for counter for-loop). Another check
might be warranted to ensure I did not overlook something.

The docs I rewrote mostly completely, to make the PVE machines a sub
point of the overall machine version, as they are not really different,
but only extend the mechanism we already used by something we can
directly control. I tried to extend the previously existing machine
version to also describe that we use that version for deciding what
to enabled/change on the PVE side, i.e., not just what QEMU exposes,
and also reduce some implementation details; another read would be
great here too, when reworking parts locally thrice or more one
starts to get to close to matter to see all obvious issues with
the changes.

While at it, I replaced the first-person plural (we) use with third
person indicative mood as documented in our style guide [0].

[0]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Person_and_Mood


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-04-06 17:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 12:53 [pve-devel] " Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 1/8] tests: cfg2cmd: add test for windows machine pinning from meta info Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 2/8] config to command: get rid of globalFlags Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 3/8] machine: correctly select pve machine version for non pinned windows guests Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 4/8] machine: incorporate pve machine version when pinning " Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 5/8] machine: add S3/S4 power state properties Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 6/8] machine: bump pve machine version and reverse the s3/s4 defaults Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 7/8] api: qemu machine capabilities: add custom pveX versions too Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH qemu-server v3 8/8] api: qemu machine capabilities: add description for pveX variants Dominik Csapak
2025-04-04 12:53 ` [pve-devel] [PATCH docs v3 1/1] qm: pve machine version: add section to explain +pveX versions Dominik Csapak
2025-04-04 16:08   ` Stoiko Ivanov
2025-04-04 15:56 ` [pve-devel] [PATCH qemu-server/docs v3] disable S3/S4 power states by default Stoiko Ivanov
2025-04-06 17:46 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd822b28-a88c-4c44-bb41-0e4129c99e8c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal