public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Markus Frank <m.frank@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs
Date: Thu, 22 Feb 2024 11:44:51 +0100	[thread overview]
Message-ID: <cc6b8704-41b3-4d2c-8b64-fbc17b6bcbdc@proxmox.com> (raw)
In-Reply-To: <a38b5af0-1d8e-4669-8a3d-e7f01f3fae39@proxmox.com>


On  2024-01-31 16:35, Fiona Ebner wrote:
> A 'migration: ' prefix would be nice for the commit title.
> 
> Am 08.11.23 um 09:52 schrieb Markus Frank:
>> add dir mapping checks to check_local_resources
>>
> 
> So, as long as there is a mapping for the target node, the migration
> check goes through. Should it? I mean, nothing ensures that the contents
> of the directory are the same on the target, or? What happens if they
> are not?
Yes. This is similar to the PCI & USB Mapping. Nothing ensures that the
mapped device/directory is the same on the other host.

If the contents are not the same they will not be the same.
But this should not be a problem as long as nothing in a VM depends on
something in the virtiofs directory.
This is something the user should take care of.
Or am I missing something?
> 
> Is migration with a directory on a shared storage reliable? With all
> cache settings?
I didn't encounter any problems.

Since the VM has to be powered off to migrate, I assume the cache gets
cleared & written to disk when virtiofs stops.

> 
> If you already tested these things, please share them in the commit
> message (and maybe also docs). Otherwise, I know nothing without testing
> myself ;)
Okay :)




  reply	other threads:[~2024-02-22 10:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  8:52 [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v8 0/7] virtiofs Markus Frank
2023-11-08  8:52 ` [pve-devel] [PATCH cluster v8 1/7] add mapping/dir.cfg for resource mapping Markus Frank
2024-01-31 12:01   ` Fiona Ebner
2023-11-08  8:52 ` [pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config Markus Frank
2024-01-31 12:01   ` Fiona Ebner
2024-01-31 13:42     ` Markus Frank
2024-01-31 13:53       ` Fiona Ebner
2024-01-31 14:00         ` Fiona Ebner
2024-01-31 14:15           ` Markus Frank
2024-01-31 13:02   ` Fiona Ebner
2023-11-08  8:52 ` [pve-devel] [PATCH docs v8 3/7] added shared filesystem doc for virtio-fs Markus Frank
2024-01-31 13:26   ` Fiona Ebner
2024-01-31 13:34   ` Fiona Ebner
2023-11-08  8:52 ` [pve-devel] [PATCH qemu-server v8 4/7] feature #1027: virtio-fs support Markus Frank
2024-01-31 15:02   ` Fiona Ebner
2024-02-13 11:52     ` Markus Frank
2024-02-13 12:04       ` Fiona Ebner
2023-11-08  8:52 ` [pve-devel] [PATCH qemu-server v8 5/7] Permission check for virtiofs directory access Markus Frank
2024-01-31 15:23   ` Fiona Ebner
2023-11-08  8:52 ` [pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs Markus Frank
2024-01-31 15:35   ` Fiona Ebner
2024-02-22 10:44     ` Markus Frank [this message]
2023-11-08  8:52 ` [pve-devel] [PATCH manager v8 7/7] api: add resource map api endpoints for directories Markus Frank
2024-01-31 15:56   ` Fiona Ebner
2024-01-30 12:31 ` [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v8 0/7] virtiofs Markus Frank
2024-01-31 12:01 ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc6b8704-41b3-4d2c-8b64-fbc17b6bcbdc@proxmox.com \
    --to=m.frank@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal