From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v5 1/1] import: allow upload of guest images files into import storage
Date: Mon, 7 Apr 2025 11:44:58 +0200 [thread overview]
Message-ID: <cc403340-4cd1-4115-951e-9c0f7070e151@proxmox.com> (raw)
In-Reply-To: <05101c04-ba1c-4baa-9e2f-49b2a5522837@proxmox.com>
Am 04.04.25 um 16:11 schrieb Fiona Ebner:
> Am 01.04.25 um 10:23 schrieb Dominik Csapak:
>> so users can upload qcow2/raw/vmdk files directly in the ui
>>
>
> Pre-existing, but we put all uploads to /var/tmp/pveupload-XYZ first,
> right? This already makes some users unhappy with ISOs IIRC and for
> images we can expect it to get worse as those are usually even larger.
> Should we at least show a warning/hint about this in the UI?
This is definitively a long-standing design deficiency and was IMO never
a good choice to use a local directory, duplicating IO and messing with
the root filesystem of a PVE.
That said, it's rather orthogonal to this feature and can be fixed later
on, considering the implications of having some not always fully trusted
fie lying around, handling cleanups, ... it might need a bit more work
to implement some sane and central mechanisms here.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 8:23 [pve-devel] [PATCH storage/manager v5] allow down/upload & import of images in the web UI Dominik Csapak
2025-04-01 8:23 ` [pve-devel] [PATCH storage v5 1/1] import: allow upload of guest images files into import storage Dominik Csapak
2025-04-04 14:11 ` Fiona Ebner
2025-04-07 9:44 ` Thomas Lamprecht [this message]
2025-04-01 8:23 ` [pve-devel] [PATCH manager v5 1/3] ui: storage content: allow upload of guest images for import type Dominik Csapak
2025-04-01 8:23 ` [pve-devel] [PATCH manager v5 2/3] ui: form: file selector: allow optional filter Dominik Csapak
2025-04-01 8:23 ` [pve-devel] [PATCH manager v5 3/3] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc403340-4cd1-4115-951e-9c0f7070e151@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal