From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] ui: resource tree: add collapse/expand all button
Date: Wed, 20 Nov 2024 09:35:44 +0100 [thread overview]
Message-ID: <cc0aace1-3a2d-45da-bc4c-296c476703f7@proxmox.com> (raw)
In-Reply-To: <822107fc-cb6e-4837-832e-96cba3f4cdff@proxmox.com>
On 11/19/24 20:56, Thomas Lamprecht wrote:
> Am 19.11.24 um 10:49 schrieb Dominik Csapak:
>> adds two buttons to the tree: expand all and collapse all
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> changes from v1:
>> * use two buttons (negates the need for all the event handling and checking)
>> * use plain plus/minus icons -> i have no real preference here either,
>> but the plain icons look a bit weird here IMHO
>
>
> It looks indeed odd, especially without padding. Did you try stacking them
> like I mentioned in my reply as possible option. Did not see anny mentioning
> that it didn't work or looked stupid ^^
no i didn't
just to clarify: you mean on top of each other?
because i think that wont work, since the buttons have a height
based on font-size/line-height/padding/margin so i guess
it's not easy to "squish" them ?
i'll try though
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-20 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:49 Dominik Csapak
2024-11-19 19:56 ` Thomas Lamprecht
2024-11-20 8:35 ` Dominik Csapak [this message]
2024-11-20 8:56 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0aace1-3a2d-45da-bc4c-296c476703f7@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox