From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer/{pve, pmg}-docs/proxmox-backup v3 0/8] raise minimum root password length to 8 characters
Date: Mon, 24 Feb 2025 12:16:22 +0100 [thread overview]
Message-ID: <cb5c87b6-8a42-43f5-bbb0-4022bbe77745@proxmox.com> (raw)
In-Reply-To: <20241216094114.476756-1-c.heiss@proxmox.com>
Am 16.12.24 um 10:40 schrieb Christoph Heiss:
> Diffstat
> ========
>
> pve-installer:
>
> Christoph Heiss (5):
> common: convert `InstallRootPassword` into an enum
> proxinstall: raise minimum root password length to 8 characters
> tui: raise minimum root password length to 8 characters
> auto: raise minimum root password length to 8 characters
> auto: add negative tests for root password option
>
> Proxmox/Sys.pm | 5 ++
> html/pbs/passwd.htm | 2 +-
> html/pmg/passwd.htm | 2 +-
> html/pve/passwd.htm | 2 +-
> proxinstall | 7 ++-
> proxmox-auto-installer/src/utils.rs | 45 ++++++++++----
> proxmox-auto-installer/tests/parse-answer.rs | 61 +++++++++++++++----
> .../tests/resources/parse_answer/btrfs.json | 2 +-
> .../tests/resources/parse_answer/btrfs.toml | 2 +-
> .../btrfs_raid_level_uppercase.json | 2 +-
> .../btrfs_raid_level_uppercase.toml | 2 +-
> .../resources/parse_answer/disk_match.json | 2 +-
> .../resources/parse_answer/disk_match.toml | 2 +-
> .../parse_answer/disk_match_all.json | 2 +-
> .../parse_answer/disk_match_all.toml | 2 +-
> .../parse_answer/disk_match_any.json | 2 +-
> .../parse_answer/disk_match_any.toml | 2 +-
> .../resources/parse_answer/first_boot.json | 2 +-
> .../resources/parse_answer/first_boot.toml | 2 +-
> .../tests/resources/parse_answer/minimal.json | 2 +-
> .../tests/resources/parse_answer/minimal.toml | 2 +-
> .../resources/parse_answer/nic_matching.json | 2 +-
> .../resources/parse_answer/nic_matching.toml | 2 +-
> .../resources/parse_answer/specific_nic.json | 2 +-
> .../resources/parse_answer/specific_nic.toml | 2 +-
> .../tests/resources/parse_answer/zfs.json | 2 +-
> .../tests/resources/parse_answer/zfs.toml | 2 +-
> .../zfs_raid_level_uppercase.json | 2 +-
> .../zfs_raid_level_uppercase.toml | 2 +-
> .../both_password_and_hashed_set.json | 3 +
> .../both_password_and_hashed_set.toml | 15 +++++
> .../no_root_password_set.json | 3 +
> .../no_root_password_set.toml | 13 ++++
> .../parse_answer_fail/short_password.json | 3 +
> .../parse_answer_fail/short_password.toml | 14 +++++
> proxmox-installer-common/src/lib.rs | 3 +
> proxmox-installer-common/src/setup.rs | 25 +++++---
> proxmox-tui-installer/src/main.rs | 10 ++-
> proxmox-tui-installer/src/setup.rs | 5 +-
> 39 files changed, 197 insertions(+), 65 deletions(-)
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/both_password_and_hashed_set.json
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/both_password_and_hashed_set.toml
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/no_root_password_set.json
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/no_root_password_set.toml
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/short_password.json
> create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/short_password.toml
>
> pve-docs:
>
> Christoph Heiss (1):
> installation: adapt to raised root password length requirement
>
> pve-installation.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> pmg-docs:
>
> Christoph Heiss (1):
> installation: adapt to raised root password length requirement
>
> pmg-installation.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> proxmox-backup:
>
> Christoph Heiss (1):
> using-the-installer: adapt to raised root password length requirement
>
> docs/using-the-installer.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
applied whole series, thanks!
I added a bit more context in the first installer patch's commit message, to
highlight that this is no semantic change and the previously theoretical
possible case of having neither password variant set was not allowed due to a
dedicated check.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-24 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 9:40 [pve-devel] " Christoph Heiss
2024-12-16 9:40 ` [pve-devel] [PATCH installer v3 1/8] common: convert `InstallRootPassword` into an enum Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH installer v3 2/8] proxinstall: raise minimum root password length to 8 characters Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH installer v3 3/8] tui: " Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH installer v3 4/8] auto: " Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH installer v3 5/8] auto: add negative tests for root password option Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH pve-docs v3 6/8] installation: adapt to raised root password length requirement Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH pmg-docs v3 7/8] " Christoph Heiss
2024-12-16 9:41 ` [pve-devel] [PATCH proxmox-backup v3 8/8] using-the-installer: " Christoph Heiss
2025-02-12 9:44 ` [pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v3 0/8] raise minimum root password length to 8 characters Christoph Heiss
2025-02-24 11:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb5c87b6-8a42-43f5-bbb0-4022bbe77745@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal