From: Lukas Wagner <l.wagner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [pbs-devel] [PATCH proxmox 2/5] router: rest-server: auth-api: use new http-error crate
Date: Wed, 26 Jul 2023 15:45:02 +0200 [thread overview]
Message-ID: <cadb8d62-e721-d1e7-adce-0035e8a770d9@proxmox.com> (raw)
In-Reply-To: <f4jzy7nv2dmovwlcdjebzrud3tece5xbjsiafhkeqcnyv2p7a3@fr4rdwfqu5uy>
On 7/26/23 15:41, Wolfgang Bumiller wrote:
> I'd like `proxmox-router` to keep re-exporting both the `http_bail/err`
> macros and the `HttpError` type. This would require much fewer changes
> at all the call sites, and we don't need to explicitly depend on the new
> crate everywhere. Its point is mostly that perlmod code doesn't need to
> pull the router into our perl code base.
Alright, I'll send a v2 with the things re-exported.
Thanks!
--
- Lukas
next prev parent reply other threads:[~2023-07-26 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 12:50 [pve-devel] [PATCH proxmox{, -perl-rs, -backup} 0/5] move `HttpError` from `proxmox-router` into its own crate Lukas Wagner
2023-07-26 12:50 ` [pve-devel] [PATCH proxmox 1/5] http-error: add new http-error crate Lukas Wagner
2023-07-26 13:35 ` [pve-devel] [pbs-devel] " Wolfgang Bumiller
2023-07-26 12:50 ` [pve-devel] [PATCH proxmox 2/5] router: rest-server: auth-api: use " Lukas Wagner
2023-07-26 13:41 ` [pve-devel] [pbs-devel] " Wolfgang Bumiller
2023-07-26 13:45 ` Lukas Wagner [this message]
2023-07-26 12:50 ` [pve-devel] [PATCH proxmox 3/5] notify: use HttpError from proxmox-http-error Lukas Wagner
2023-07-26 12:50 ` [pve-devel] [PATCH proxmox-perl-rs 4/5] notify: use new HttpError type Lukas Wagner
2023-07-26 12:50 ` [pve-devel] [PATCH proxmox-backup 5/5] use `HttpError` and macros from `proxmox-http-error` crate Lukas Wagner
2023-07-26 13:42 ` [pve-devel] [pbs-devel] " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cadb8d62-e721-d1e7-adce-0035e8a770d9@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox