From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Filip Schauer" <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] oci create: fix creating privileged containers
Date: Wed, 26 Nov 2025 09:59:13 +0100 [thread overview]
Message-ID: <cacecfef-9865-450f-8fb9-20600fba4d72@proxmox.com> (raw)
In-Reply-To: <742bf33d-88d6-4de9-b55b-642a67df309f@proxmox.com>
Am 26.11.25 um 09:54 schrieb Thomas Lamprecht:
> Am 26.11.25 um 09:31 schrieb Fabian Grünbichler:
>> On November 25, 2025 3:19 pm, Filip Schauer wrote:
>>> Previously, creating privileged containers from OCI images failed with:
>>> `unable to create CT 123 - Invalid argument`
>>>
>>> This was caused by an empty $id_map being passed to run_in_userns.
>>>
>>> This commit fixes this by making the call to run_in_userns conditional,
>>> based on whether $id_map is empty or not.
>>>
>>> Reported in the Proxmox forum:
>>> https://forum.proxmox.com/threads/proxmox-virtual-environment-9-1-available.176255/post-818600
>>>
>>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
>> or we could forbid creating them, since we want to get rid of privileged
>> containers mid-to-longterm anyway?
>
> Yeah, I had a similar reply as draft here. If it never worked at all for OCI,
> that might be indeed the better route. It might be better to put your energy
(your = Filip)
> into improving the UX for unprivileged CTs (uid shifts, bind mounts, ...?)
> so that any still existing need (or simply less friction) for using privileged
> ones goes away. As with that we could indeed start sunsetting them with PVE 10
> (e.g. remove from UI in that version, then in PVE 11 from the create API, only
> allowing to run pre-existing CTs).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-26 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 14:19 Filip Schauer
2025-11-26 8:31 ` Fabian Grünbichler
2025-11-26 8:55 ` Thomas Lamprecht
2025-11-26 8:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cacecfef-9865-450f-8fb9-20600fba4d72@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox