From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] fix #3610: properly build ZFS detail tree
Date: Thu, 9 Sep 2021 18:24:27 +0200 [thread overview]
Message-ID: <c9d43541-02c9-3480-b7e9-333aca6e27ac@proxmox.com> (raw)
In-Reply-To: <20210907093055.39627-1-f.ebner@proxmox.com>
On 07.09.21 11:30, Fabian Ebner wrote:
> Previously, top-level vdevs like log or special were wrongly added as
> children of the previous outer vdev instead of the root.
>
> Fix it by also showing the vdev with the same name as the pool and
> start counting from level 1 (the pool itself serves as the root and
> should be the only one with level 0). This results in the same kind
> of structure as in PBS and (except for the root) zpool status itself.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Disks/ZFS.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
> index 0418794..60077c4 100644
> --- a/PVE/API2/Disks/ZFS.pm
> +++ b/PVE/API2/Disks/ZFS.pm
> @@ -240,8 +240,8 @@ __PACKAGE__->register_method ({
> $config = 1;
> } elsif ($config && $line =~ m/^(\s+)(\S+)\s*(\S+)?(?:\s+(\S+)\s+(\S+)\s+(\S+))?\s*(.*)$/) {
> my ($space, $name, $state, $read, $write, $cksum, $msg) = ($1, $2, $3, $4, $5, $6, $7);
> - if ($name ne "NAME" and $name ne $param->{name}) {
> - my $lvl= int(length($space)/2); # two spaces per level
> + if ($name ne "NAME") {
> + my $lvl = int(length($space) / 2) + 1; # two spaces per level
> my $vdev = {
> name => $name,
> msg => $msg,
>
hmm, I get the idea and can see how one could assert that this is more correct,
but as it is presented it'd be a bit more confusing too, IMO, as it does not
matches the zpool status CLI output anymore.
I.e., the following (real):
> NAME STATE READ WRITE CKSUM
> zpt ONLINE 0 0 0
> mirror-0 ONLINE 0 0 0
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi3 ONLINE 0 0 0
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi4 ONLINE 0 0 0
> logs
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi5 ONLINE 0 0 0
Is suggested to be (adapted):
> NAME STATE READ WRITE CKSUM
> zpt ONLINE
> zpt ONLINE 0 0 0
> mirror-0 ONLINE 0 0 0
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi3 ONLINE 0 0 0
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi4 ONLINE 0 0 0
> logs
> scsi-0QEMU_QEMU_HARDDISK_drive-scsi5 ONLINE 0 0 0
How about hiding the root in the devices tree and add a line to the
KV grid above instead? E.g., something that would then render:
Pool <ID> (<STATUS>)
That can be a GUI change only, did not really checked implementation details, but
I'd like to clear that up before applying this patch.
next prev parent reply other threads:[~2021-09-09 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:30 Fabian Ebner
2021-09-09 16:24 ` Thomas Lamprecht [this message]
2021-09-10 8:03 ` Fabian Ebner
2021-09-10 8:05 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d43541-02c9-3480-b7e9-333aca6e27ac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox