From: Filip Schauer <f.schauer@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 container 1/2] fix #5160: fix move_mount regression for mount point hotplug
Date: Tue, 9 Apr 2024 11:27:36 +0200 [thread overview]
Message-ID: <c93d1c93-de37-4850-a447-bd2267fa41b9@proxmox.com> (raw)
In-Reply-To: <mucnjjldfri77fnrhhx6ouqjc3valdous6r6i3fxvdyyny3blo@cyj4xeixwf6u>
Agreed. This appear to be a leftover from testing. A patch v3 with this
removed is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/062693.html
On 09/04/2024 10:23, Wolfgang Bumiller wrote:
>> diff --gita/src/pve-container-debug@.service b/src/pve-container-debug@.service
>> index 7cfebaa..cd0895c 100644
>> ---a/src/pve-container-debug@.service
>> +++b/src/pve-container-debug@.service
>> @@ -13,6 +13,7 @@ Type=simple
>> Delegate=yes
>> KillMode=mixed
>> TimeoutStopSec=120s
>> +ExecStartPre=/lib/apparmor/profile-load pve-container-mounthotplug
>> ExecStart=/usr/bin/lxc-start -F -n %i -o /dev/stderr -l DEBUG
>> ExecStop=/usr/share/lxc/pve-container-stop-wrapper %i
>> # Environment=BOOTUP=serial
> ^ This hunk should be dropped. The entry in d/rules is enough, and this
> is the wrong place anyway, as this is triggered when starting a new
> container, and not when hotplugging.
next prev parent reply other threads:[~2024-04-09 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:28 [pve-devel] [PATCH v2 container 0/2] " Filip Schauer
2024-03-25 17:28 ` [pve-devel] [PATCH v2 container 1/2] " Filip Schauer
2024-04-09 8:23 ` Wolfgang Bumiller
2024-04-09 9:27 ` Filip Schauer [this message]
2024-03-25 17:28 ` [pve-devel] [PATCH v2 container 2/2] fix undef warning when apparmor changeprofile fails Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c93d1c93-de37-4850-a447-bd2267fa41b9@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox