From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-network 1/2] api: refactor URL structure for Ipam
Date: Mon, 20 Nov 2023 17:43:06 +0100 [thread overview]
Message-ID: <c938b0f2-fde1-4a21-bf4e-d868fd644d2c@proxmox.com> (raw)
In-Reply-To: <20231120162833.431139-2-s.hanreich@proxmox.com>
Am 20/11/2023 um 17:28 schrieb Stefan Hanreich:
> The initial URL structure was less than optimal due to Ipam as well as
> Ipams being endpoints in the API, which are too similar and might be
> confusing to users.
>
> Move the listing of PVE IPAM to /ipams/pve/status
> Move the create / update / delete endpoints to /vnets/{vnetid}/ips
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> src/PVE/API2/Network/SDN.pm | 6 --
> src/PVE/API2/Network/SDN/Ipams.pm | 83 +++++++++++++++++
> src/PVE/API2/Network/SDN/{Ipam.pm => Ips.pm} | 97 ++------------------
> src/PVE/API2/Network/SDN/Makefile | 2 +-
> src/PVE/API2/Network/SDN/Vnets.pm | 6 ++
> 5 files changed, 100 insertions(+), 94 deletions(-)
> rename src/PVE/API2/Network/SDN/{Ipam.pm => Ips.pm} (58%)
>
>
applied, this one, thanks!
next prev parent reply other threads:[~2023-11-20 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 16:28 [pve-devel] [PATCH network/manager 0/2] Refactor IPAM API methods Stefan Hanreich
2023-11-20 16:28 ` [pve-devel] [PATCH pve-network 1/2] api: refactor URL structure for Ipam Stefan Hanreich
2023-11-20 16:43 ` Thomas Lamprecht [this message]
2023-11-20 16:28 ` [pve-devel] [PATCH pve-manager 2/2] sdn: Update IPAM API endpoints Stefan Hanreich
2023-11-21 21:14 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c938b0f2-fde1-4a21-bf4e-d868fd644d2c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox