From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] vzdump: use minimal VM config for offline backup
Date: Mon, 7 Sep 2020 09:05:15 +0200 [thread overview]
Message-ID: <c8554742-95f2-5d60-e891-202255c17785@proxmox.com> (raw)
In-Reply-To: <b7916e00-ee6f-3624-9d3f-68eee1ac0872@proxmox.com>
On 07.09.20 08:59, Dominik Csapak wrote:
> does that not break the feature that
> we can start a vm that started a backup while stopped?
>
> atm we can start a backup on a stopped vm, and then simply start
> it, without aborting the backup. if i read the patch
> correctly, the vm now has just a minimal config and not
> what the user configured
>
Yes, as the commit subject mentions, the whole idea of the patch was to use
a minimal config ;-)
this was before I talked about the whole "no shutdown" thing for VMs, where
Stefan acknowledged himself that this patch breaks various things, existing
and planned, about that behavior.
We should had replied that to this patch too though.
prev parent reply other threads:[~2020-09-07 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:21 Stefan Reiter
2020-09-07 6:59 ` Dominik Csapak
2020-09-07 7:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8554742-95f2-5d60-e891-202255c17785@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox