Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd

[Matthias Heiserer <m.heiserer@proxmox.com>]

On 15.03.2023 12:10, Dominik Csapak wrote:
> hi not sure we would want to do it this way, since
> this will only work for the node where the new pve-cluster
> is installed, the other nodes will not be able to update their
> local database with the info from the new nodes
> 
> AFAIR, the way we dealt with rrd updates in the past is
> that we introduced a new db (like pve2.3-vm) which is also
> not available on older nodes, but it does not error out, since
> it won't match and we don't try to update it
I thought I had tested that and it would just discard the value, instead 
of erroring. but I'll check again, not sure rn
> 
> On 1/25/23 12:29, Matthias Heiserer wrote:
>> To modify the existing rrd store, rrdtool is required
>>
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>   data/src/status.c           | 1 +
>>   debian/control              | 1 +
>>   debian/pve-cluster.postinst | 6 ++++++
>>   3 files changed, 8 insertions(+)
>>   create mode 100644 debian/pve-cluster.postinst
>>
>> diff --git a/data/src/status.c b/data/src/status.c
>> index 5e1e841..9290141 100644
>> --- a/data/src/status.c
>> +++ b/data/src/status.c
>> @@ -1130,6 +1130,7 @@ static const char *rrd_def_node[] = {
>>       "DS:rootused:GAUGE:120:0:U",
>>       "DS:netin:DERIVE:120:0:U",
>>       "DS:netout:DERIVE:120:0:U",
>> +    "DS:arcsize:GAUGE:120:0:U",
>>       "RRA:AVERAGE:0.5:1:70", // 1 min avg - one hour
>>       "RRA:AVERAGE:0.5:30:70", // 30 min avg - one day
>> diff --git a/debian/control b/debian/control
>> index 2d5a01f..22d96c2 100644
>> --- a/debian/control
>> +++ b/debian/control
>> @@ -37,6 +37,7 @@ Depends: corosync (>= 2.3.4-1),
>>            libsqlite3-0,
>>            sqlite3,
>>            systemd,
>> +         rrdtool,
>>            ${misc:Depends},
>>            ${perl:Depends},
>>            ${shlibs:Depends},
>> diff --git a/debian/pve-cluster.postinst b/debian/pve-cluster.postinst
>> new file mode 100644
>> index 0000000..cf475cc
>> --- /dev/null
>> +++ b/debian/pve-cluster.postinst
>> @@ -0,0 +1,6 @@
>> +#!/bin/bash
>> +
>> +RRD_DB="/var/lib/rrdcached/db/pve2-node/`hostname`"
>> +if [ -f $RRD_DB ] && [ `rrdtool info $RRD_DB | grep -q arcsize` ]; then
>> +        rrdtool tune $RRD_DB 'DS:arcsize:GAUGE:120:0:U'
>> +fi
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>