From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/6] assistant: properly validate answer file settings
Date: Tue, 10 Dec 2024 18:37:18 +0100 [thread overview]
Message-ID: <c80040d2-204c-49fb-9639-44a43cf53b85@proxmox.com> (raw)
In-Reply-To: <20241209124601.1272122-1-c.heiss@proxmox.com>
Am 09.12.24 um 13:45 schrieb Christoph Heiss:
> Currently, the answer file is only syntax-checked, i.e. if it can be
> parsed as TOML and whether it is of valid structure, but the actual
> answer settings are not looked at.
>
> Patch #2 is a refactoring of the whole locale info generation, as to
> generate the final information structure at build-time - thus being able
> to include it in the auto-install-assistant for verify answer file
> settings.
>
> Christoph Heiss (6):
> tui: options: simplify unit-test setup
> country.pl: generate final structure as json at build time directly
> common: setup: read locale info as shipped by the installer directly
> common: setup: include path in error message if file could not be read
> fix #5889: assistant: validate answer email & root password settings
> assistant: validate answer first-boot hook and locale settings
>
> .gitignore | 2 +-
> Makefile | 16 +--
> Proxmox/Install/ISOEnv.pm | 56 +--------
> country.pl | 116 ++++++++++++++----
> proxmox-auto-install-assistant/src/main.rs | 18 ++-
> proxmox-auto-installer/src/utils.rs | 6 +-
> .../tests/resources/iso-info.json | 2 +-
> proxmox-installer-common/src/setup.rs | 34 +++--
> proxmox-low-level-installer | 3 -
> proxmox-tui-installer/src/options.rs | 26 +---
> 10 files changed, 152 insertions(+), 127 deletions(-)
>
applied series, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-12-10 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 12:45 [pve-devel] " Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 1/6] tui: options: simplify unit-test setup Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 2/6] country.pl: generate final structure as json at build time directly Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 3/6] common: setup: read locale info as shipped by the installer directly Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 4/6] common: setup: include path in error message if file could not be read Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 5/6] fix #5889: assistant: validate answer email & root password settings Christoph Heiss
2024-12-09 12:45 ` [pve-devel] [PATCH installer 6/6] assistant: validate answer first-boot hook and locale settings Christoph Heiss
2024-12-10 17:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c80040d2-204c-49fb-9639-44a43cf53b85@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox