From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH qemu-server] pci: add 'keep-driver' option
Date: Tue, 26 Aug 2025 12:24:08 +0200 [thread overview]
Message-ID: <c7ccd821-fc9d-4618-a260-b2c8c29edebf@proxmox.com> (raw)
In-Reply-To: <ddb5b93a-9e28-4f07-866a-9e33cda611ad@proxmox.com>
On 26/08/2025 12:15, Dominik Csapak wrote:
> of course, i did not do it for an RFC because i did not expect it to go
> in like this without discussion/refining anyway. the next version
That's fine, especially here where it's doesn't changes anything,
for things with much change it might be even nice to have a test
for an RFC, as then one sees what changes here; but I mostly
mentioned the test as a general reminder for everyone, because we
all sometimes forget adding one even though it's rather cheap to do
so.
> will have cfg2command tests (though it does not change anything on
> the command line currently, so the tests will just test that the config
> is parseable)
That's fine for now.
We might want to expand cfg2cmd to test more side-effects that should,
or should not, happen. That could also be a separate test harness
that is just derived from cfg2cmd, to avoid making it overly complex,
but just to air out some thoughts, as that is definitively nothing for
this series and probably quite a bit more work.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-26 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 10:00 Dominik Csapak
2025-08-26 10:11 ` Thomas Lamprecht
2025-08-26 10:14 ` Dominik Csapak
2025-08-26 10:24 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ccd821-fc9d-4618-a260-b2c8c29edebf@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox