public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH corosync-pve/kronosnet 0/4] cherry-pick bug fixes
Date: Tue, 9 Nov 2021 13:31:37 +0100	[thread overview]
Message-ID: <c7978044-4902-4e06-5cdd-e12151a7504f@proxmox.com> (raw)
In-Reply-To: <20211109120742.3276270-1-f.gruenbichler@proxmox.com>

On 09.11.21 13:07, Fabian Grünbichler wrote:
> culmination of 4 weeks of triaging together with the respective upstream
> devs and endless hours staring at corosync debug traces, this fixes the
> following issues:
> 
> - knet losing join messages if network is overloaded, pushing corosync
>   into a retransmit loop, potentially causing a full-cluster fence event
>   with just a single node acting up
> - corosync potentially corrupting messages during membership changes
> 
> and another one reported by someone else:
> 
> - corosync causing high network load by not holding the token in case
>   messages are queued for retransmission
> 
> all of the fixes are taken from the respective stable queue with
> releases slated for later this week.
> 
> corosync:
> 
> Fabian Grünbichler (2):
>   cherry-pick fixes
>   bump version to 3.1.5-pve2
> 
>  ...cel_hold_on_retransmit-config-option.patch | 132 ++++++++++++++++++
>  ...ch-totempg-buffers-at-the-right-time.patch | 113 +++++++++++++++
>  debian/changelog                              |   8 ++
>  debian/patches/series                         |   2 +
>  4 files changed, 255 insertions(+)
>  create mode 100644 debian/patches/0003-totem-Add-cancel_hold_on_retransmit-config-option.patch
>  create mode 100644 debian/patches/0004-totemsrp-Switch-totempg-buffers-at-the-right-time.patch
> 
> kronosnet:
> 
> Fabian Grünbichler (2):
>   fix #3672: cherry-pick knet fixes
>   bump version to 1.22-pve2
> 
>  ...eq_num-initialization-race-condition.patch | 53 +++++++++++
>  ...or-messages-to-trigger-faster-link-d.patch | 92 +++++++++++++++++++
>  debian/changelog                              |  6 ++
>  debian/patches/series                         |  3 +-
>  4 files changed, 153 insertions(+), 1 deletion(-)
>  create mode 100644 debian/patches/0001-host-fix-dst_seq_num-initialization-race-condition.patch
>  create mode 100644 debian/patches/0002-udp-use-ICMP-error-messages-to-trigger-faster-link-d.patch
> 

For all of this:

Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

Can you go a head and push + upload packages?




  parent reply	other threads:[~2021-11-09 12:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 12:07 Fabian Grünbichler
2021-11-09 12:07 ` [pve-devel] [PATCH corosync-pve 1/2] cherry-pick fixes Fabian Grünbichler
2021-11-09 12:07 ` [pve-devel] [PATCH corosync-pve 2/2] bump version to 3.1.5-pve2 Fabian Grünbichler
2021-11-09 12:07 ` [pve-devel] [PATCH kronosnet 1/2] fix #3672: cherry-pick knet fixes Fabian Grünbichler
2021-11-09 12:07 ` [pve-devel] [PATCH kronosnet 2/2] bump version to 1.22-pve2 Fabian Grünbichler
2021-11-09 12:31 ` Thomas Lamprecht [this message]
2021-11-09 12:54   ` [pve-devel] applied-series: [PATCH corosync-pve/kronosnet 0/4] cherry-pick bug fixes Fabian Grünbichler
2021-11-09 13:21     ` Eneko Lacunza
2021-11-09 17:39       ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7978044-4902-4e06-5cdd-e12151a7504f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal