* [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers
@ 2021-11-29 12:38 Oguz Bektas
2021-12-01 14:54 ` Dylan Whyte
0 siblings, 1 reply; 3+ messages in thread
From: Oguz Bektas @ 2021-11-29 12:38 UTC (permalink / raw)
To: pve-devel
requested in community forum [0]
root@CT1022:/# mount | grep lazy
/var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on / type ext4 (rw,relatime,lazytime)
/var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)
[0]: https://forum.proxmox.com/threads/100454/
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 1e28a88..6c2acd6 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
-my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
+my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
sub is_valid_mount_option {
my ($option) = @_;
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers
2021-11-29 12:38 [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers Oguz Bektas
@ 2021-12-01 14:54 ` Dylan Whyte
2021-12-01 15:11 ` Oguz Bektas
0 siblings, 1 reply; 3+ messages in thread
From: Dylan Whyte @ 2021-12-01 14:54 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas
Hi,
I just tested/played with this a bit and couldn't find any issues within
the container, with the option enabled.
However, you need to add a corresponding mount option in the GUI, as
otherwise, the "Edit: Mount Point" window breaks due to it not
recognizing the option, and no changes can be made as a result.
Tested-by: Dylan Whyte <d.whyte@proxmox.com>
On 11/29/21 1:38 PM, Oguz Bektas wrote:
> requested in community forum [0]
>
> root@CT1022:/# mount | grep lazy
> /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on / type ext4 (rw,relatime,lazytime)
> /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)
>
> [0]: https://forum.proxmox.com/threads/100454/
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> src/PVE/LXC/Config.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 1e28a88..6c2acd6 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
> cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
>
>
> -my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
> +my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
>
> sub is_valid_mount_option {
> my ($option) = @_;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers
2021-12-01 14:54 ` Dylan Whyte
@ 2021-12-01 15:11 ` Oguz Bektas
0 siblings, 0 replies; 3+ messages in thread
From: Oguz Bektas @ 2021-12-01 15:11 UTC (permalink / raw)
To: Dylan Whyte; +Cc: Proxmox VE development discussion
On Wed, Dec 01, 2021 at 03:54:12PM +0100, Dylan Whyte wrote:
> Hi,
>
> I just tested/played with this a bit and couldn't find any issues within the
> container, with the option enabled.
>
> However, you need to add a corresponding mount option in the GUI, as
> otherwise, the "Edit: Mount Point" window breaks due to it not recognizing
> the option, and no changes can be made as a result.
oops yeah, thanks for pointing out! will send a manager patch :)
>
> Tested-by: Dylan Whyte <d.whyte@proxmox.com>
>
> On 11/29/21 1:38 PM, Oguz Bektas wrote:
> > requested in community forum [0]
> >
> > root@CT1022:/# mount | grep lazy
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on / type ext4 (rw,relatime,lazytime)
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)
> >
> > [0]: https://forum.proxmox.com/threads/100454/
> >
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> > src/PVE/LXC/Config.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index 1e28a88..6c2acd6 100644
> > --- a/src/PVE/LXC/Config.pm
> > +++ b/src/PVE/LXC/Config.pm
> > @@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
> > cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
> > -my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
> > +my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
> > sub is_valid_mount_option {
> > my ($option) = @_;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-01 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 12:38 [pve-devel] [PATCH] config: allow 'lazytime' mount option for containers Oguz Bektas
2021-12-01 14:54 ` Dylan Whyte
2021-12-01 15:11 ` Oguz Bektas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox